Changeset 59428

Timestamp:

11/20/2024 01:53:57 AM (20 months ago)

Author:

desrosj

Message:

Menus: i18n: Fix untranslatable strings in nav-menu.js.

Wrap three untranslatable strings in nav menus in JS translation functions.

Follow up to [59265].

Reviewed by desrosj, joedolson.
Merges 59426 to the 6.7 branch.

Props juliemoynat, swissspidy, yogeshbhutkar, sergeybiryukov, desrosj, tobifjellner, audrasjb, joedolson.
Fixes #62402.

Location:

branches/6.7

Files:

• . (modified) (1 prop)
• src/js/_enqueues/lib/nav-menu.js (modified) (3 diffs)

branches/6.7/src/js/_enqueues/lib/nav-menu.js

@@ -320 +320 @@
                                                         }
 
-                                                        $html += '<option ' + $selected + ' value="0">No Parent</option>';
+                                                        $html += '<option ' + $selected + ' value="0">' + wp.i18n._x( 'No Parent', 'menu item without a parent in navigation menu' ) + '</option>';
 
                                                         $.each( menuItems, function() {
@@ -365 +365 @@
                                                                                 $selected = 'selected';
                                                                         }
-                                                                        $html += '<option ' + $selected + ' value="' + i + '">' + i + ' of ' + totalMenuItems + '</option>';
+                                                                        // Translators: %1$s is the current menu item number, %2$s is the total number of menu items.
+                                                                        var itemString = wp.i18n.sprintf( 
+                                                                                wp.i18n._x( '%1$s of %2$s', 'indicating a part of a total number of items in a navigation menu' ),
+                                                                                i,
+                                                                                totalMenuItems
+                                                                        );
+                                                                        $html += '<option ' + $selected + ' value="' + i + '">' + itemString + '</option>';
                                                                 }
 
@@ -381 +387 @@
                                                                                 $selected = 'selected';
                                                                         }
-                                                                        $html += '<option ' + $selected + ' value="' + i + '">' + i + ' of ' + totalSubMenuItems + '</option>';
+                                                                        // Translators: %1$s is the current submenu item number, %2$s is the total number of submenu items.
+                                                                        var submenuString = wp.i18n.sprintf( 
+                                                                                wp.i18n._x( '%1$s of %2$s', 'indicating a part of a total number of items in a submenu' ),
+                                                                                i,
+                                                                                totalSubMenuItems
+                                                                        );
+                                                                        $html += '<option ' + $selected + ' value="' + i + '">' + submenuString + '</option>';
                                                                 }