Changeset 59430 for trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php

Timestamp:

11/20/2024 02:48:40 AM (23 months ago)

Author:

desrosj

Message:

i18n: Account for load_*_textdomain() after JIT loading.

When load_*_textdomain() functions are called after WordPress has already attempted just-in-time loading of translations, nothing happens.

This updates the related logic to retry translation loading when a custom path is set to ensure all translations are available.

Additionally, this also fixes cases where an en_US.mo file is provided with non-English strings to override the default language.

Follow up to [59157].

Props swissspidy, peterwilsoncc, desrosj, apermo, sergeybiryukov, wildworks, tigriweb, twvania, looswebstudio, stimul, audrasjb, finntown, bluantinoo, timwhitlock, albigdd.
See #62337.

File:

• trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php (modified) (1 diff)

trunk/tests/phpunit/tests/l10n/loadTextdomainJustInTime.php

@@ -343 +343 @@
                 $this->assertSame( 1, $filter->get_call_count() );
         }
+
+        /**
+         * @ticket 44937
+         * @ticket 62337
+         *
+         * @covers ::load_plugin_textdomain
+         * @covers ::is_textdomain_loaded
+         * @covers WP_Textdomain_Registry::set_custom_path
+         */
+        public function test_plugin_translation_should_be_translated_when_calling_load_plugin_textdomain_too_late() {
+                require_once DIR_TESTDATA . '/plugins/custom-internationalized-plugin/custom-internationalized-plugin.php';
+
+                add_filter( 'locale', array( $this, 'filter_set_locale_to_german' ) );
+
+                $is_textdomain_loaded_before = is_textdomain_loaded( 'custom-internationalized-plugin' );
+                $output_before               = custom_i18n_plugin_test();
+
+                $is_textdomain_loaded_middle = is_textdomain_loaded( 'custom-internationalized-plugin' );
+
+                custom_i18n_load_textdomain();
+
+                $output_after               = custom_i18n_plugin_test();
+                $is_textdomain_loaded_after = is_textdomain_loaded( 'custom-internationalized-plugin' );
+
+                $this->assertFalse( $is_textdomain_loaded_before );
+                $this->assertFalse( $is_textdomain_loaded_middle );
+                $this->assertSame( 'This is a dummy plugin', $output_before );
+                $this->assertSame( 'Das ist ein Dummy Plugin', $output_after );
+                $this->assertTrue( $is_textdomain_loaded_after );
+        }
 }