Changeset 59442

Timestamp:

11/20/2024 09:27:18 PM (15 months ago)

Author:

joemcgill

Message:

Editor: Avoid unnecessary array_merge in WP_Style_Engine::parse_block_styles().

This adds an ! empty() check for classnames and declarations to avoid calling array_merge() with an empty value.

Props mukesh27, ramonopoly, aaronrobertshaw.
Fixes #62317.

File:

• trunk/src/wp-includes/style-engine/class-wp-style-engine.php (modified) (1 diff)

trunk/src/wp-includes/style-engine/class-wp-style-engine.php

@@ -455 +455 @@
                 }
 
-                $parsed_styles['classnames']   = array_merge( $parsed_styles['classnames'], static::get_classnames( $style_value, $style_definition ) );
-                $parsed_styles['declarations'] = array_merge( $parsed_styles['declarations'], static::get_css_declarations( $style_value, $style_definition, $options ) );
+                $classnames = static::get_classnames( $style_value, $style_definition );
+                if ( ! empty( $classnames ) ) {
+                    $parsed_styles['classnames'] = array_merge( $parsed_styles['classnames'], $classnames );
+                }
+
+                $css_declarations = static::get_css_declarations( $style_value, $style_definition, $options );
+                if ( ! empty( $css_declarations ) ) {
+                    $parsed_styles['declarations'] = array_merge( $parsed_styles['declarations'], $css_declarations );
+                }
             }
         }