Changeset 59450

Timestamp:

11/22/2024 12:50:48 PM (2 months ago)

Author:

cbravobernal

Message:

HTML API: Prevent fragment creation on close tag.

Prevent fragments from being created at tag closers.

Follow-up to [59444].

Props jonsurrell, bernhard-reiter.
Fixes #62357.

Location:

trunk

Files:

• src/wp-includes/html-api/class-wp-html-processor.php (modified) (1 diff)
• tests/phpunit/tests/html-api/wpHtmlProcessor.php (modified) (1 diff)

trunk/src/wp-includes/html-api/class-wp-html-processor.php

@@ -465 +465 @@
      */
     public function create_fragment_at_current_node( string $html ) {
-        if ( $this->get_token_type() !== '#tag' ) {
+        if ( $this->get_token_type() !== '#tag' || $this->is_tag_closer() ) {
             return null;
         }

trunk/tests/phpunit/tests/html-api/wpHtmlProcessor.php

@@ -1105 +1105 @@
 
     /**
+     * @ticket 62357
+     */
+    public function test_prevent_fragment_creation_on_closers() {
+        $processor = WP_HTML_Processor::create_full_parser( '<p></p>' );
+        $processor->next_tag( 'P' );
+        $processor->next_tag(
+            array(
+                'tag_name'    => 'P',
+                'tag_closers' => 'visit',
+            )
+        );
+        $this->assertSame( 'P', $processor->get_tag() );
+        $this->assertTrue( $processor->is_tag_closer() );
+        $this->assertNull( $processor->create_fragment_at_current_node( '<i>fragment HTML</i>' ) );
+    }
+
+    /**
      * Ensure that lowercased tag_name query matches tags case-insensitively.
      *