Changeset 59453

Timestamp:

11/22/2024 07:17:35 PM (9 days ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Explicitly return null instead of coercing void.

This addresses two instances where a function that is documented as returning {someType}|null doesn't explicitly return null.

Affected functions:

• array_key_first()
• WP_REST_Posts_Controller::handle_terms()

Follow-up to [38832], [52038].

Props justlevine.
See #52217.

Location:

trunk/src/wp-includes

Files:

• compat.php (modified) (1 diff)
• rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)

trunk/src/wp-includes/compat.php

@@ -416 +416 @@
      */
     function array_key_first( array $array ) { // phpcs:ignore Universal.NamingConventions.NoReservedKeywordParameterNames.arrayFound
+        if ( empty( $array ) ) {
+            return null;
+        }
+
         foreach ( $array as $key => $value ) {
             return $key;

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1650 +1650 @@
             }
         }
+
+        return null;
     }