Changeset 59462

Timestamp:

11/26/2024 09:15:31 PM (5 days ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Cast wp_count_terms() result to int before using in ceil().

This addresses two instances of the (numeric string) return value from wp_count_terms() being used directly in ceil(), which expects an int|float.

Affected methods:

• WP_Sitemaps_Taxonomies::get_max_num_pages()
• wp_nav_menu_item_taxonomy_meta_box()

Reference: ​PHP Manual: ceil().

Follow-up to [14248], [14291], [14569], [14943], [48072], [57648].

Props justlevine.
See #52217.

Location:

trunk/src

Files:

• wp-admin/includes/nav-menu.php (modified) (1 diff)
• wp-includes/sitemaps/providers/class-wp-sitemaps-taxonomies.php (modified) (1 diff)

trunk/src/wp-admin/includes/nav-menu.php

@@ -876 +876 @@
 
     $num_pages = (int) ceil(
-        wp_count_terms(
+        (int) wp_count_terms(
             array_merge(
                 $args,

trunk/src/wp-includes/sitemaps/providers/class-wp-sitemaps-taxonomies.php

@@ -172 +172 @@
         $term_count = wp_count_terms( $this->get_taxonomies_query_args( $taxonomy ) );
 
-        return (int) ceil( $term_count / wp_sitemaps_get_max_urls( $this->object_type ) );
+        return (int) ceil( (int) $term_count / wp_sitemaps_get_max_urls( $this->object_type ) );
     }