Changeset 59466

Timestamp:

11/27/2024 02:28:55 PM (15 months ago)

Author:

swissspidy

Message:

I18N: Do not reuse $theme variable name after loading a theme's functions.php file.

The file could declare its own $theme variable, which would override the one used in the foreach loop.

To prevent this, call wp_get_theme() before loading the file and store the instance in a different variable.

Props neo2k23, swissspidy.
See #62244.

File:

• trunk/src/wp-settings.php (modified) (1 diff)

trunk/src/wp-settings.php

@@ -680 +680 @@
 // Load the functions for the active theme, for both parent and child theme if applicable.
 foreach ( wp_get_active_and_valid_themes() as $theme ) {
+    $wp_theme = wp_get_theme( basename( $theme ) );
+
     if ( file_exists( $theme . '/functions.php' ) ) {
         include $theme . '/functions.php';
     }
 
-    $theme = wp_get_theme( basename( $theme ) );
-    $theme->load_textdomain();
-}
-unset( $theme );
+    $wp_theme->load_textdomain();
+}
+unset( $theme, $wp_theme );
 
 /**