Changeset 59482 for trunk/src/wp-includes/blocks.php

Timestamp:

12/04/2024 12:05:33 PM (8 months ago)

Author:

Bernhard Reiter

Message:

Block Hooks: Fix context in update_ignored_hooked_blocks_postmeta.

Ensure that the $context arg passed from update_ignored_hooked_blocks_postmeta to apply_block_hooks_to_content (and from there, to filters such as hooked_block_types and hooked_block) has the correct type (WP_Post).

Filters hooked to hooked_block_types etc can typically include checks that conditionally insert a hooked block depending on $context. Prior to this changeset, a check like if ( $context instanceof WP_Post ) would incorrectly fail, as $context would be a stdClass instance rather than a WP_Post. As a consequence, a hooked block inside of a Navigation post object that was modified by the user would not be marked as ignored by update_ignored_hooked_blocks_postmeta, and thus be erroneosly re-inserted by the Block Hooks algorithm.

Props bernhard-reiter.
Fixes #62639.

File:

• trunk/src/wp-includes/blocks.php (modified) (1 diff)

trunk/src/wp-includes/blocks.php

@@ -1218 +1218 @@
     // Merge the existing post object with the updated post object to pass to the block hooks algorithm for context.
     $context          = (object) array_merge( (array) $existing_post, (array) $post );
+    $context          = new WP_Post( $context ); // Convert to WP_Post object.
     $serialized_block = apply_block_hooks_to_content( $markup, $context, 'set_ignored_hooked_blocks_metadata' );
     $root_block       = parse_blocks( $serialized_block )[0];