Changeset 59493

Timestamp:

12/05/2024 09:19:37 PM (14 months ago)

Author:

swissspidy

Message:

Embeds: ensure correct thumbnail height.

Use height 0 instead of 9999 to avoid unnecessarily using the full size version.

Props colinleroy, swissspidy.
Fixes #62094.

Location:

trunk

Files:

• src/wp-includes/embed.php (modified) (1 diff)
• tests/phpunit/tests/oembed/getResponseData.php (modified) (1 diff)

trunk/src/wp-includes/embed.php

@@ -722 +722 @@
 
     if ( $thumbnail_id ) {
-        list( $thumbnail_url, $thumbnail_width, $thumbnail_height ) = wp_get_attachment_image_src( $thumbnail_id, array( $width, 99999 ) );
+        list( $thumbnail_url, $thumbnail_width, $thumbnail_height ) = wp_get_attachment_image_src( $thumbnail_id, array( $width, 0 ) );
         $data['thumbnail_url']                                      = $thumbnail_url;
         $data['thumbnail_width']                                    = $thumbnail_width;

trunk/tests/phpunit/tests/oembed/getResponseData.php

@@ -252 +252 @@
     }
 
+    /**
+     * @ticket 62094
+     */
+    public function test_get_oembed_response_data_has_correct_thumbnail_size() {
+        $post = self::factory()->post->create_and_get();
+
+        /* Use a large image as post thumbnail */
+        $attachment_id = self::factory()->attachment->create_upload_object( DIR_TESTDATA . '/images/33772.jpg' );
+        set_post_thumbnail( $post, $attachment_id );
+
+        /* Get the image, sized for 400x??? pixels display */
+        $image = wp_get_attachment_image_src( $attachment_id, array( 400, 0 ) );
+
+        /* Get the oembed data array for a 400 pixels wide embed */
+        $data = get_oembed_response_data( $post, 400 );
+
+        /* Make sure the embed references the small image, not the full-size one. */
+        $this->assertSame( $image[0], $data['thumbnail_url'] );
+    }
+
     public function test_get_oembed_response_data_for_attachment() {
         $parent = self::factory()->post->create();