Changeset 59517 for trunk/tests/phpunit/tests/https-detection.php

Timestamp:

12/16/2024 02:06:05 PM (22 months ago)

Author:

flixos90

Message:

Site Health: Remove use of deprecated function from wp_is_https_supported().

Follow up to [56664].

Props peter8nss, debarghyabanerjee, sebastienserre, geekofshire, swissspidy, desrosj.
Fixes #62252.
See #58494.

File:

• trunk/tests/phpunit/tests/https-detection.php (modified) (1 diff)

trunk/tests/phpunit/tests/https-detection.php

@@ -42 +42 @@
          */
         public function test_wp_is_https_supported() {
-                // The function works with cached errors, so only test that here.
-                $wp_error = new WP_Error();
+                // Simulate that HTTPS is supported by returning an empty error array.
+                add_filter(
+                        'pre_wp_get_https_detection_errors',
+                        function () {
+                                return new WP_Error(); // No errors means HTTPS is supported.
+                        }
+                );
 
                 // No errors, so HTTPS is supported.
-                update_option( 'https_detection_errors', $wp_error->errors );
                 $this->assertTrue( wp_is_https_supported() );
 
-                // Errors, so HTTPS is not supported.
-                $wp_error->add( 'ssl_verification_failed', 'SSL verification failed.' );
-                update_option( 'https_detection_errors', $wp_error->errors );
+                // Now we simulate that HTTPS is not supported by returning errors.
+                $support_errors = new WP_Error();
+                $support_errors->add( 'ssl_verification_failed', 'SSL verification failed.' );
+
+                // Short-circuit the detection logic to return our simulated errors.
+                add_filter(
+                        'pre_wp_get_https_detection_errors',
+                        function () use ( $support_errors ) {
+                                return $support_errors;
+                        }
+                );
+
+                // Test that HTTPS is not supported due to the simulated errors.
                 $this->assertFalse( wp_is_https_supported() );
+
+                // Remove the filter to avoid affecting other tests.
+                remove_filter( 'pre_wp_get_https_detection_errors', '__return_null' );
         }