Changeset 59519

Timestamp:

12/16/2024 07:27:59 PM (7 months ago)

Author:

desrosj

Message:

Build/Test Tools: Update slackapi/slack-github-action.

This makes the necessary changes to update the Slack GitHub Action to the latest version, currently 2.0.0.

Most notably this update provides more control over how attempts re retried when rate limiting is encountered.

Reverts [59209].

See #61701, #62221.

File:

• trunk/.github/workflows/slack-notifications.yml (modified) (8 diffs)

trunk/.github/workflows/slack-notifications.yml

@@ -162 +162 @@
     name: Failure notifications
     runs-on: ubuntu-latest
-    continue-on-error: true
-    timeout-minutes: 5
+    timeout-minutes: 10
     needs: [ prepare ]
     if: ${{ needs.prepare.outputs.previous_conclusion != 'first-failure' && inputs.calling_status == 'failure' || failure() }}
@@ -169 +168 @@
     steps:
       - name: Post failure notifications to Slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
-        with:
-          payload: ${{ needs.prepare.outputs.payload }}
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
+        uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
+        with:
+          webhook-type: webhook-trigger
+          webhook: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
+          payload: ${{ needs.prepare.outputs.payload }}
 
   # Posts notifications the first time a workflow run succeeds after previously failing.
@@ -179 +178 @@
     name: Fixed notifications
     runs-on: ubuntu-latest
-    continue-on-error: true
-    timeout-minutes: 5
+    timeout-minutes: 10
     needs: [ prepare ]
     if: ${{ contains( fromJson( '["failure", "cancelled", "none"]' ), needs.prepare.outputs.previous_conclusion ) && inputs.calling_status == 'success' && success() }}
@@ -186 +184 @@
     steps:
       - name: Post failure notifications to Slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
-        with:
-          payload: ${{ needs.prepare.outputs.payload }}
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
+        uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
+        with:
+          webhook-type: webhook-trigger
+          webhook: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
+          payload: ${{ needs.prepare.outputs.payload }}
 
   # Posts notifications when a workflow is successful.
@@ -196 +194 @@
     name: Success notifications
     runs-on: ubuntu-latest
-    continue-on-error: true
-    timeout-minutes: 5
+    timeout-minutes: 10
     needs: [ prepare ]
     if: ${{ inputs.calling_status == 'success' && success() }}
@@ -203 +200 @@
     steps:
       - name: Post success notifications to Slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
-        with:
-          payload: ${{ needs.prepare.outputs.payload }}
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
+        uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
+        with:
+          webhook-type: webhook-trigger
+          webhook: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
+          payload: ${{ needs.prepare.outputs.payload }}
 
   # Posts notifications when a workflow is cancelled.
@@ -213 +210 @@
     name: Cancelled notifications
     runs-on: ubuntu-latest
-    continue-on-error: true
-    timeout-minutes: 5
+    timeout-minutes: 10
     needs: [ prepare ]
     if: ${{ inputs.calling_status == 'cancelled' || cancelled() }}
@@ -220 +216 @@
     steps:
       - name: Post cancelled notifications to Slack
-        uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
-        with:
-          payload: ${{ needs.prepare.outputs.payload }}
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
+        uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
+        with:
+          webhook-type: webhook-trigger
+          webhook: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
+          payload: ${{ needs.prepare.outputs.payload }}