Changeset 59540

Timestamp:

12/19/2024 03:07:09 AM (22 months ago)

Author:

peterwilsoncc

Message:

External Libraries: Append .1 to react/react-dom versions.

Replaces the -umd appendage for the react and react-dom script versions with .1. This it to prevent issues with third party code expecting the version number in the form /^[\d\.]+$/.

Updates the version to tests in Tests_Dependencies_Scripts::test_vendor_script_versions_registered_manually to include the modified version used for cache busting.

Follow up to [59536], [58775].

Props azaozz, desrosj, peterwilsoncc.
Fixes #62422.

Location:

trunk

Files:

• src/wp-includes/script-loader.php (modified) (1 diff)
• tests/phpunit/tests/dependencies/scripts.php (modified) (1 diff)

trunk/src/wp-includes/script-loader.php

@@ -107 +107 @@
 
         $vendor_scripts_versions = array(
-                'react'                       => '18.3.1-umd',
-                'react-dom'                   => '18.3.1-umd',
+                'react'                       => '18.3.1.1', // Final .1 due to switch to UMD build, can be removed in the next update.
+                'react-dom'                   => '18.3.1.1', // Final .1 due to switch to UMD build, can be removed in the next update.
                 'react-jsx-runtime'           => '18.3.1',
                 'regenerator-runtime'         => '0.14.1',

trunk/tests/phpunit/tests/dependencies/scripts.php

@@ -3414 +3414 @@
                 }
 
+                /*
+                 * Append '.1' to the version number for React and ReactDOM.
+                 *
+                 * This is due to a change in the build to use the UMD version of the
+                 * scripts, requiring a different version number in order to break the
+                 * caches of some CDNs.
+                 *
+                 * This can be removed in the next update to the packages.
+                 *
+                 * See https://core.trac.wordpress.org/ticket/62422
+                 */
+                if ( in_array( $handle, array( 'react', 'react-dom' ), true ) ) {
+                        $package_json[ $script ] .= '.1';
+                }
+
                 $script_query = $wp_scripts->query( $handle, 'registered' );