Changeset 59579

Timestamp:

01/06/2025 03:58:50 PM (2 months ago)

Author:

SergeyBiryukov

Message:

Tests: Improve the test for the copyright year in bundled themes' readme.txt.

This aims to catch entries like (C) 2024 WordPress.org in addition to Copyright 2024 WordPress.org.

Includes converting the test to use a data provider, so that messages could be displayed for each individual theme.

Follow-up to [46719], [59569].

See #62280.

File:

• trunk/tests/phpunit/tests/theme.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme.php

@@ -303 +303 @@
     /**
      * @ticket 48566
-     */
-    public function test_year_in_readme() {
+     *
+     * @dataProvider data_year_in_readme
+     */
+    public function test_year_in_readme( $theme ) {
         // This test is designed to only run on trunk.
         $this->skipOnAutomatedBranches();
 
-        foreach ( $this->default_themes as $theme ) {
-            $wp_theme = wp_get_theme( $theme );
-
-            $path_to_readme_txt = $wp_theme->get_theme_root() . '/' . $wp_theme->get_stylesheet() . '/readme.txt';
-            $this->assertFileExists( $path_to_readme_txt );
-
-            $readme    = file_get_contents( $path_to_readme_txt );
-            $this_year = gmdate( 'Y' );
-
-            preg_match( '#Copyright (\d+) WordPress.org#', $readme, $matches );
-            if ( $matches ) {
-                $readme_year = trim( $matches[1] );
-
-                $this->assertSame( $this_year, $readme_year, "Bundled themes readme.txt's year needs to be updated to $this_year." );
-            }
-
-            preg_match( '#Copyright 20\d\d-(\d+) WordPress.org#', $readme, $matches );
-            if ( $matches ) {
-                $readme_year = trim( $matches[1] );
-
-                $this->assertSame( $this_year, $readme_year, "Bundled themes readme.txt's year needs to be updated to $this_year." );
-            }
+        $wp_theme = wp_get_theme( $theme );
+
+        $path_to_readme_txt = $wp_theme->get_theme_root() . '/' . $wp_theme->get_stylesheet() . '/readme.txt';
+        $this->assertFileExists( $path_to_readme_txt );
+
+        $readme    = file_get_contents( $path_to_readme_txt );
+        $this_year = gmdate( 'Y' );
+
+        preg_match( '#(Copyright|\(C\)) (20\d\d-)?(\d+) WordPress.org#i', $readme, $matches );
+        if ( $matches ) {
+            $readme_year = trim( $matches[3] );
+
+            $this->assertSame( $this_year, $readme_year, "$theme readme.txt's year needs to be updated to $this_year." );
         }
+    }
+
+    public function data_year_in_readme() {
+        return array_map(
+            static function ( $theme ) {
+                return array( $theme );
+            },
+            $this->default_themes
+        );
     }