Changeset 59599

Timestamp:

01/12/2025 06:12:14 PM (3 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in get_page_by_path().

Follow-up to [3511], [18541], [19075], [21845].

Props aristath, poena, afercia, SergeyBiryukov.
See #62279.

File:

• trunk/src/wp-includes/post.php (modified) (4 diffs)

trunk/src/wp-includes/post.php

@@ -6062 +6062 @@
     $revparts = array_reverse( $parts );
 
-    $foundid = 0;
+    $found_id = 0;
     foreach ( (array) $pages as $page ) {
-        if ( $page->post_name == $revparts[0] ) {
+        if ( $page->post_name === $revparts[0] ) {
             $count = 0;
             $p     = $page;
@@ -6072 +6072 @@
              * ensuring each matches the post ancestry.
              */
-            while ( 0 != $p->post_parent && isset( $pages[ $p->post_parent ] ) ) {
+            while ( 0 !== (int) $p->post_parent && isset( $pages[ $p->post_parent ] ) ) {
                 ++$count;
                 $parent = $pages[ $p->post_parent ];
-                if ( ! isset( $revparts[ $count ] ) || $parent->post_name != $revparts[ $count ] ) {
+                if ( ! isset( $revparts[ $count ] ) || $parent->post_name !== $revparts[ $count ] ) {
                     break;
                 }
@@ -6081 +6081 @@
             }
 
-            if ( 0 == $p->post_parent && count( $revparts ) === $count + 1 && $p->post_name == $revparts[ $count ] ) {
-                $foundid = $page->ID;
-                if ( $page->post_type == $post_type ) {
+            if ( 0 === (int) $p->post_parent
+                && count( $revparts ) === $count + 1
+                && $p->post_name === $revparts[ $count ]
+            ) {
+                $found_id = $page->ID;
+                if ( $page->post_type === $post_type ) {
                     break;
                 }
@@ -6091 +6094 @@
 
     // We cache misses as well as hits.
-    wp_cache_set( $cache_key, $foundid, 'post-queries' );
-
-    if ( $foundid ) {
-        return get_post( $foundid, $output );
+    wp_cache_set( $cache_key, $found_id, 'post-queries' );
+
+    if ( $found_id ) {
+        return get_post( $found_id, $output );
     }