Changeset 59630 for trunk/tests/phpunit/tests/rest-api/rest-global-styles-revisions-controller.php

Timestamp:

01/15/2025 06:34:35 PM (19 months ago)

Author:

flixos90

Message:

REST API: Fix PHP warning about undefined paged argument in various REST API endpoints.

This bug could occur in WP_REST_Posts_Controller, WP_REST_Global_Styles_Revisions_Controller, WP_REST_Revisions_Controller, and any of their child classes. This changeset fixes it throughout.

Props apermo, pbearne, hemant-ahir, flixos90.
Fixes #62292.

File:

• trunk/tests/phpunit/tests/rest-api/rest-global-styles-revisions-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-global-styles-revisions-controller.php

@@ -827 +827 @@
         }
 
+
+        /**
+         * Tests for the pagination.
+         *
+         * @ticket 62292
+         *
+         * @covers WP_REST_Global_Styles_Controller::get_items
+         */
+        public function test_get_global_styles_revisions_pagination() {
+                wp_set_current_user( self::$admin_id );
+
+                // Test offset
+                $request = new WP_REST_Request( 'GET', '/wp/v2/global-styles/' . self::$global_styles_id . '/revisions' );
+                $request->set_param( 'offset', 1 );
+                $request->set_param( 'per_page', 1 );
+                $response = rest_get_server()->dispatch( $request );
+                $this->assertEquals( 200, $response->get_status() );
+                $data = $response->get_data();
+                $this->assertCount( 1, $data );
+                $this->assertEquals( 3, $response->get_headers()['X-WP-Total'] );
+                $this->assertEquals( 3, $response->get_headers()['X-WP-TotalPages'] );
+
+                // Test paged
+                $request = new WP_REST_Request( 'GET', '/wp/v2/global-styles/' . self::$global_styles_id . '/revisions' );
+                $request->set_param( 'page', 2 );
+                $request->set_param( 'per_page', 2 );
+                $response = rest_get_server()->dispatch( $request );
+                $this->assertEquals( 200, $response->get_status() );
+                $data = $response->get_data();
+                $this->assertCount( 1, $data );
+                $this->assertEquals( 3, $response->get_headers()['X-WP-Total'] );
+                $this->assertEquals( 2, $response->get_headers()['X-WP-TotalPages'] );
+
+                // Test out of bounds
+                $request = new WP_REST_Request( 'GET', '/wp/v2/global-styles/' . self::$global_styles_id . '/revisions' );
+                $request->set_param( 'page', 4 );
+                $request->set_param( 'per_page', 6 );
+                $response = rest_get_server()->dispatch( $request );
+                $this->assertErrorResponse( 'rest_revision_invalid_page_number', $response, 400 );
+        }
+
         /**
          * @doesNotPerformAssertions