Changeset 59665

Timestamp:

01/20/2025 02:30:02 PM (4 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Rename the $isPrimary variable in wp_xmlrpc_server methods.

This resolves a few WPCS warnings:

Variable "$isPrimary" is not in valid snake_case format, try "$is_primary"

Additionally, this commit renames $catids to $cat_ids for consistency.

Follow-up to [1671].

See #62279.

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -6088 +6088 @@
 
             $categories = array();
-            $catids     = wp_get_post_categories( $post_id );
-            foreach ( $catids as $catid ) {
-                $categories[] = get_cat_name( $catid );
+            $cat_ids    = wp_get_post_categories( $post_id );
+            foreach ( $cat_ids as $cat_id ) {
+                $categories[] = get_cat_name( $cat_id );
             }
 
@@ -6240 +6240 @@
 
             $categories = array();
-            $catids     = wp_get_post_categories( $entry['ID'] );
-            foreach ( $catids as $catid ) {
-                $categories[] = get_cat_name( $catid );
+            $cat_ids    = wp_get_post_categories( $entry['ID'] );
+            foreach ( $cat_ids as $cat_id ) {
+                $categories[] = get_cat_name( $cat_id );
             }
 
@@ -6640 +6640 @@
 
         $categories = array();
-        $catids     = wp_get_post_categories( (int) $post_id );
+        $cat_ids    = wp_get_post_categories( (int) $post_id );
         // First listed category will be the primary category.
-        $isPrimary = true;
-        foreach ( $catids as $catid ) {
+        $is_primary = true;
+        foreach ( $cat_ids as $cat_id ) {
             $categories[] = array(
-                'categoryName' => get_cat_name( $catid ),
-                'categoryId'   => (string) $catid,
-                'isPrimary'    => $isPrimary,
+                'categoryName' => get_cat_name( $cat_id ),
+                'categoryId'   => (string) $cat_id,
+                'isPrimary'    => $is_primary,
             );
-            $isPrimary    = false;
+            $is_primary   = false;
         }
 
@@ -6694 +6694 @@
         }
 
-        $catids = array();
+        $cat_ids = array();
         foreach ( $categories as $cat ) {
-            $catids[] = $cat['categoryId'];
-        }
-
-        wp_set_post_categories( $post_id, $catids );
+            $cat_ids[] = $cat['categoryId'];
+        }
+
+        wp_set_post_categories( $post_id, $cat_ids );
 
         return true;