Changeset 59674 for trunk/src/wp-includes/class-walker-nav-menu.php

Timestamp:

01/21/2025 09:24:59 PM (5 months ago)

Author:

westonruter

Message:

Menus: Improve performance by calling get_privacy_policy_url() once per Walker_Nav_Menu instance rather than for every nav menu item.

The start_el() method in Walker_Nav_Menu was calling get_privacy_policy_url() for every menu item when building menus. This resulted in redundant queries, particularly for menus with many items. This obtains the get_privacy_policy_url() value in the constructor for reuse in the start_el() method to improve performance.

Redundant code to construct the privacy policy page is also refactored into the set_up() method during tests.

Props arzola, swissspidy, westonruter, mukesh27.
Fixes #62818.

File:

• trunk/src/wp-includes/class-walker-nav-menu.php (modified) (2 diffs)

trunk/src/wp-includes/class-walker-nav-menu.php

@@ -41 +41 @@
 
     /**
+     * The URL to the privacy policy page.
+     *
+     * @since 6.8.0
+     * @var string
+     */
+    private $privacy_policy_url;
+
+    /**
+     * Constructor.
+     *
+     * @since 6.8.0
+     */
+    public function __construct() {
+        $this->privacy_policy_url = get_privacy_policy_url();
+    }
+
+    /**
      * Starts the list before the elements are added.
      *
@@ -237 +254 @@
 
         if ( ! empty( $menu_item->url ) ) {
-            if ( get_privacy_policy_url() === $menu_item->url ) {
+            if ( $this->privacy_policy_url === $menu_item->url ) {
                 $atts['rel'] = empty( $atts['rel'] ) ? 'privacy-policy' : $atts['rel'] . ' privacy-policy';
             }