Changeset 59675

Timestamp:

01/21/2025 09:47:27 PM (20 months ago)

Author:

audrasjb

Message:

Themes: Remove title attributes from theme list tables.

This changeset updates the old list tables for themes and theme installation to remove title attributes or replace them with a more acessible implementation:

• Removes title attributes from span elements
• Replaces title with aria-label for links whose visible text starts with the same word, consistently with links on the "Add Plugins" screen
• Reuses the $preview_title variable to keep ARIA labels consistent for both Preview links

Follow-up to [22439], [27548], [31513], [32991], [50804], [53414].

Props karlgroves, sabernhardt, audrasjb, alh0319.
Fixes #62834.
See #24766.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-theme-install-list-table.php (modified) (7 diffs)
• class-wp-themes-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

@@ -316 +316 @@
                         case 'update_available':
                                 $actions[] = sprintf(
-                                        '<a class="install-now" href="%s" title="%s">%s</a>',
+                                        '<a class="install-now" href="%s" aria-label="%s">%s</a>',
                                         esc_url( wp_nonce_url( $update_url, 'upgrade-theme_' . $theme->slug ) ),
                                         /* translators: %s: Theme version. */
@@ -326 +326 @@
                         case 'latest_installed':
                                 $actions[] = sprintf(
-                                        '<span class="install-now" title="%s">%s</span>',
-                                        esc_attr__( 'This theme is already installed and is up to date' ),
+                                        '<span class="install-now">%s</span>',
                                         _x( 'Installed', 'theme' )
                                 );
@@ -334 +333 @@
                         default:
                                 $actions[] = sprintf(
-                                        '<a class="install-now" href="%s" title="%s">%s</a>',
+                                        '<a class="install-now" href="%s" aria-label="%s">%s</a>',
                                         esc_url( wp_nonce_url( $install_url, 'install-theme_' . $theme->slug ) ),
                                         /* translators: %s: Theme name. */
@@ -344 +343 @@
 
                 $actions[] = sprintf(
-                        '<a class="install-theme-preview" href="%s" title="%s">%s</a>',
+                        '<a class="install-theme-preview" href="%s" aria-label="%s">%s</a>',
                         esc_url( $preview_url ),
-                        /* translators: %s: Theme name. */
-                        esc_attr( sprintf( __( 'Preview %s' ), $name ) ),
+                        esc_attr( $preview_title ),
                         __( 'Preview' )
                 );
@@ -364 +362 @@
 
                 ?>
-                <a class="screenshot install-theme-preview" href="<?php echo esc_url( $preview_url ); ?>" title="<?php echo esc_attr( $preview_title ); ?>">
+                <a class="screenshot install-theme-preview" href="<?php echo esc_url( $preview_url ); ?>" aria-label="<?php echo esc_attr( $preview_title ); ?>">
                         <img src="<?php echo esc_url( $theme->screenshot_url . '?ver=' . $theme->version ); ?>" width="150" alt="" />
                 </a>
@@ -475 +473 @@
                         case 'update_available':
                                 printf(
-                                        '<a class="theme-install button button-primary" href="%s" title="%s">%s</a>',
+                                        '<a class="theme-install button button-primary" href="%s" aria-label="%s">%s</a>',
                                         esc_url( wp_nonce_url( $update_url, 'upgrade-theme_' . $theme->slug ) ),
                                         /* translators: %s: Theme version. */
@@ -485 +483 @@
                         case 'latest_installed':
                                 printf(
-                                        '<span class="theme-install" title="%s">%s</span>',
-                                        esc_attr__( 'This theme is already installed and is up to date' ),
+                                        '<span class="theme-install">%s</span>',
                                         _x( 'Installed', 'theme' )
                                 );

trunk/src/wp-admin/includes/class-wp-themes-list-table.php

@@ -212 +212 @@
                         $actions             = array();
                         $actions['activate'] = sprintf(
-                                '<a href="%s" class="activatelink" title="%s">%s</a>',
+                                '<a href="%s" class="activatelink" aria-label="%s">%s</a>',
                                 $activate_link,
                                 /* translators: %s: Theme name. */