Changeset 59690

Timestamp:

01/22/2025 10:31:06 PM (21 months ago)

Author:

audrasjb

Message:

Administration: Remove useless arrow icon from WordPress admin menu.

This changeset deletes the arrow that is typically added next to WordPress admin menu items that have submenus. The .wp-menu-arrow element is no longer visible since the WP 3.8 redesign, but the HTML and CSS remained. With this changeset, the HTML generating the arrow is removed, and the corresponding CSS styling is deleted.

Props helen, azaozz, jbkkd, pbearne, flixos90.
Fixes #26960.

Location:

trunk

Files:

• src/wp-admin/css/admin-menu.css (modified) (2 diffs)
• src/wp-admin/menu-header.php (modified) (3 diffs)
• tests/qunit/index.html (modified) (1 diff)

trunk/src/wp-admin/css/admin-menu.css

@@ -181 +181 @@
 #adminmenu li.wp-has-current-submenu a.wp-has-current-submenu,
 #adminmenu li.current a.menu-top,
-#adminmenu .wp-menu-arrow,
-#adminmenu .wp-has-current-submenu .wp-submenu .wp-submenu-head,
-#adminmenu .wp-menu-arrow div {
+#adminmenu .wp-has-current-submenu .wp-submenu .wp-submenu-head {
         background: #2271b1;
         color: #fff;
@@ -332 +330 @@
 .sticky-menu #adminmenuwrap {
         position: fixed;
-}
-
-/* A new arrow */
-
-.wp-menu-arrow {
-        display: none !important;
 }
 

trunk/src/wp-admin/menu-header.php

@@ -143 +143 @@
                         }
                 }
-                $arrow = '<div class="wp-menu-arrow"><div></div></div>';
 
                 $title = wptexturize( $item[0] );
@@ -172 +171 @@
                         ) {
                                 $admin_is_parent = true;
-                                echo "<a href='admin.php?page={$submenu_items[0][2]}'$class $aria_attributes>$arrow<div class='wp-menu-image$img_class'$img_style aria-hidden='true'>$img</div><div class='wp-menu-name'>$title</div></a>";
+                                echo "<a href='admin.php?page={$submenu_items[0][2]}'$class $aria_attributes><div class='wp-menu-image$img_class'$img_style aria-hidden='true'>$img</div><div class='wp-menu-name'>$title</div></a>";
                         } else {
-                                echo "\n\t<a href='{$submenu_items[0][2]}'$class $aria_attributes>$arrow<div class='wp-menu-image$img_class'$img_style aria-hidden='true'>$img</div><div class='wp-menu-name'>$title</div></a>";
+                                echo "\n\t<a href='{$submenu_items[0][2]}'$class $aria_attributes><div class='wp-menu-image$img_class'$img_style aria-hidden='true'>$img</div><div class='wp-menu-name'>$title</div></a>";
                         }
                 } elseif ( ! empty( $item[2] ) && current_user_can( $item[1] ) ) {
@@ -191 +190 @@
                         ) {
                                 $admin_is_parent = true;
-                                echo "\n\t<a href='admin.php?page={$item[2]}'$class $aria_attributes>$arrow<div class='wp-menu-image$img_class'$img_style aria-hidden='true'>$img</div><div class='wp-menu-name'>{$item[0]}</div></a>";
+                                echo "\n\t<a href='admin.php?page={$item[2]}'$class $aria_attributes><div class='wp-menu-image$img_class'$img_style aria-hidden='true'>$img</div><div class='wp-menu-name'>{$item[0]}</div></a>";
                         } else {
-                                echo "\n\t<a href='{$item[2]}'$class $aria_attributes>$arrow<div class='wp-menu-image$img_class'$img_style aria-hidden='true'>$img</div><div class='wp-menu-name'>{$item[0]}</div></a>";
+                                echo "\n\t<a href='{$item[2]}'$class $aria_attributes><div class='wp-menu-image$img_class'$img_style aria-hidden='true'>$img</div><div class='wp-menu-name'>{$item[0]}</div></a>";
                         }
                 }

trunk/tests/qunit/index.html

@@ -2293 +2293 @@
                         <li class="wp-has-submenu wp-not-current-submenu menu-top menu-icon-plugins" id="menu-plugins">
                                 <a href="plugins.php" class="wp-has-submenu wp-not-current-submenu menu-top menu-icon-plugins" aria-haspopup="true">
-                                        <div class="wp-menu-arrow"><div></div></div>
                                         <div class="wp-menu-image dashicons-before dashicons-admin-plugins"><br></div>
                                         <div class="wp-menu-name">Plugins