Changeset 59697

Timestamp:

01/24/2025 12:02:08 AM (4 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Rename the $ID variable in wp_xmlrpc_server methods.

This resolves a WPCS warning:

Variable "$ID" is not in valid snake_case format, try "$i_d"

Follow-up to [28448].

See #62279.

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (7 diffs)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -5144 +5144 @@
         $post_date_gmt = current_time( 'mysql', 1 );
 
-        $post_data = compact( 'post_author', 'post_date', 'post_date_gmt', 'post_content', 'post_title', 'post_category', 'post_status' );
+        $post_data = compact(
+            'post_author',
+            'post_date',
+            'post_date_gmt',
+            'post_content',
+            'post_title',
+            'post_category',
+            'post_status'
+        );
 
         $post_id = wp_insert_post( $post_data );
@@ -5596 +5604 @@
         }
 
-        $postdata = compact( 'post_author', 'post_date', 'post_date_gmt', 'post_content', 'post_title', 'post_category', 'post_status', 'post_excerpt', 'comment_status', 'ping_status', 'to_ping', 'post_type', 'post_name', 'post_password', 'post_parent', 'menu_order', 'tags_input', 'page_template' );
+        $postdata = compact(
+            'post_author',
+            'post_date',
+            'post_date_gmt',
+            'post_content',
+            'post_title',
+            'post_category',
+            'post_status',
+            'post_excerpt',
+            'comment_status',
+            'ping_status',
+            'to_ping',
+            'post_type',
+            'post_name',
+            'post_password',
+            'post_parent',
+            'menu_order',
+            'tags_input',
+            'page_template'
+        );
 
         $post_id        = get_default_post_to_edit( $post_type, true )->ID;
@@ -5778 +5805 @@
         $this->escape( $postdata );
 
-        $ID             = $postdata['ID'];
+        $post_id        = $postdata['ID'];
         $post_content   = $postdata['post_content'];
         $post_title     = $postdata['post_title'];
@@ -5980 +6007 @@
 
         // We've got all the data -- post it.
-        $newpost = compact( 'ID', 'post_content', 'post_title', 'post_category', 'post_status', 'post_excerpt', 'comment_status', 'ping_status', 'edit_date', 'post_date', 'post_date_gmt', 'to_ping', 'post_name', 'post_password', 'post_parent', 'menu_order', 'post_author', 'tags_input', 'page_template' );
+        $newpost = compact(
+            'post_id',
+            'post_content',
+            'post_title',
+            'post_category',
+            'post_status',
+            'post_excerpt',
+            'comment_status',
+            'ping_status',
+            'edit_date',
+            'post_date',
+            'post_date_gmt',
+            'to_ping',
+            'post_name',
+            'post_password',
+            'post_parent',
+            'menu_order',
+            'post_author',
+            'tags_input',
+            'page_template'
+        );
 
         $result = wp_update_post( $newpost, true );
@@ -6023 +6070 @@
         $this->add_enclosure_if_new( $post_id, $enclosure );
 
-        $this->attach_uploads( $ID, $post_content );
+        $this->attach_uploads( $post_id, $post_content );
 
         // Handle post formats if assigned, validation is handled earlier in this function.
@@ -6459 +6506 @@
 
         // Save the data.
-        $id = wp_insert_attachment( $attachment, $upload['file'], $post_id );
-        wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $upload['file'] ) );
+        $attachment_id = wp_insert_attachment( $attachment, $upload['file'], $post_id );
+        wp_update_attachment_metadata( $attachment_id, wp_generate_attachment_metadata( $attachment_id, $upload['file'] ) );
 
         /**
@@ -6467 +6514 @@
          * @since 3.4.0
          *
-         * @param int   $id   ID of the new attachment.
-         * @param array $args An array of arguments to add the attachment.
+         * @param int   $attachment_id ID of the new attachment.
+         * @param array $args          An array of arguments to add the attachment.
          */
-        do_action( 'xmlrpc_call_success_mw_newMediaObject', $id, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
-
-        $struct = $this->_prepare_media_item( get_post( $id ) );
+        do_action( 'xmlrpc_call_success_mw_newMediaObject', $attachment_id, $args ); // phpcs:ignore WordPress.NamingConventions.ValidHookName.NotLowercase
+
+        $struct = $this->_prepare_media_item( get_post( $attachment_id ) );
 
         // Deprecated values.