Make WordPress Core

Changeset 59703


Ignore:
Timestamp:
01/24/2025 10:58:32 PM (3 months ago)
Author:
audrasjb
Message:

Posts, Post Types: Remove title attribute from the_shortlink().

Since [13683], the_shortlink() has included a title attribute. By default, that gives the sanitized post title, and it does not sanitize custom text. Given the low value of this attribute, this changeset removes it.

Props sabernhardt, audrasjb, joedolson.
Fixes #62838.
See #24766.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/link-template.php

    r59533 r59703  
    42484248 *
    42494249 * @since 3.0.0
    4250  *
    4251  * @param string $text   Optional The link text or HTML to be displayed. Defaults to 'This is the short link.'
    4252  * @param string $title  Optional The tooltip for the link. Must be sanitized. Defaults to the sanitized post title.
    4253  * @param string $before Optional HTML to display before the link. Default empty.
    4254  * @param string $after  Optional HTML to display after the link. Default empty.
     4250 * @since 6.8.0 Removed title attribute.
     4251 *
     4252 * @param string $text   Optional. The link text or HTML to be displayed. Defaults to 'This is the short link.'
     4253 * @param string $title  Unused.
     4254 * @param string $before Optional. HTML to display before the link. Default empty.
     4255 * @param string $after  Optional. HTML to display after the link. Default empty.
    42554256 */
    42564257function the_shortlink( $text = '', $title = '', $before = '', $after = '' ) {
     
    42614262    }
    42624263
    4263     if ( empty( $title ) ) {
    4264         $title = the_title_attribute( array( 'echo' => false ) );
    4265     }
    4266 
    42674264    $shortlink = wp_get_shortlink( $post->ID );
    42684265
    42694266    if ( ! empty( $shortlink ) ) {
    4270         $link = '<a rel="shortlink" href="' . esc_url( $shortlink ) . '" title="' . $title . '">' . $text . '</a>';
     4267        $link = '<a rel="shortlink" href="' . esc_url( $shortlink ) . '">' . $text . '</a>';
    42714268
    42724269        /**
     
    42784275         * @param string $shortlink Shortlink URL.
    42794276         * @param string $text      Shortlink's text.
    4280          * @param string $title     Shortlink's title attribute.
     4277         * @param string $title     Shortlink's title attribute. Unused.
    42814278         */
    42824279        $link = apply_filters( 'the_shortlink', $link, $shortlink, $text, $title );
Note: See TracChangeset for help on using the changeset viewer.