Changeset 59715

Timestamp:

01/27/2025 11:05:21 PM (3 months ago)

Author:

spacedmonkey

Message:

Revisions: Use WP_Query in wp_get_post_autosave.

Replaced the raw SQL query in the wp_get_post_autosave function with a WP_Query call. This change improves code maintainability and replaces the raw SQL query with a cacheable query via WP_Query.

Props narenin, swissspidy, mukesh27, spacedmonkey, im3dabasia1.
Fixes #62658.

Location:

trunk

Files:

• src/wp-includes/revision.php (modified) (2 diffs)
• tests/phpunit/tests/post/wpGetAutoSave.php (added)

trunk/src/wp-includes/revision.php

@@ -271 +271 @@
  * @since 2.6.0
  *
- * @global wpdb $wpdb WordPress database abstraction object.
- *
  * @param int $post_id The post ID.
  * @param int $user_id Optional. The post author ID. Default 0.
@@ -278 +276 @@
  */
 function wp_get_post_autosave( $post_id, $user_id = 0 ) {
-    global $wpdb;
-
-    $autosave_name = $post_id . '-autosave-v1';
-    $user_id_query = ( 0 !== $user_id ) ? "AND post_author = $user_id" : null;
-
-    // Construct the autosave query.
-    $autosave_query = "
-        SELECT *
-        FROM $wpdb->posts
-        WHERE post_parent = %d
-        AND post_type = 'revision'
-        AND post_status = 'inherit'
-        AND post_name   = %s " . $user_id_query . '
-        ORDER BY post_date DESC
-        LIMIT 1';
-
-    $autosave = $wpdb->get_results(
-        $wpdb->prepare(
-            $autosave_query,
-            $post_id,
-            $autosave_name
-        )
+    $args = array(
+        'post_type'      => 'revision',
+        'post_status'    => 'inherit',
+        'post_parent'    => $post_id,
+        'name'           => $post_id . '-autosave-v1',
+        'posts_per_page' => 1,
+        'orderby'        => 'date',
+        'order'          => 'DESC',
+        'fields'         => 'ids',
+        'no_found_rows'  => true,
     );
 
-    if ( ! $autosave ) {
+    if ( 0 !== $user_id ) {
+        $args['author'] = $user_id;
+    }
+
+    $query = new WP_Query( $args );
+
+    if ( ! $query->have_posts() ) {
         return false;
     }
 
-    return get_post( $autosave[0] );
+    return get_post( $query->posts[0] );
 }