Changeset 59741 for branches/6.7

Timestamp:

01/30/2025 08:42:03 PM (7 weeks ago)

Author:

jorbin

Message:

External Libraries: Append .1 to react/react-dom versions.

In 6.7, [58775] changed the way react and react-dom are bundled in Core. This commit resulted in some changes to the built files that are distributed in WordPress even though the actual version of the libraries remained the same. The result can be a blank white screen when trying to edit a post when those two script files are heavily cached.

This uses .1 as the appendage to prevent issues with third party code expecting the version number in the form /^[\d\.]+$/.

Updates include tests in Tests_Dependencies_Scripts::test_vendor_script_versions_registered_manually to include the modified version used for cache busting.

Reviewed by jorbin.
Merges [59536] and [59540] to 6.7 branch.

Props levskipg, get_dave, smerriman, jdnd, juanwp22, seanlanglands, robertstaddon, azaozz, peterwilsoncc, desrosj.
Fixes #62422.

Location:

branches/6.7

Files:

• . (modified) (1 prop)
• src/wp-includes/script-loader.php (modified) (1 diff)
• tests/phpunit/tests/dependencies/scripts.php (modified) (1 diff)

branches/6.7/src/wp-includes/script-loader.php

@@ -107 +107 @@
 
     $vendor_scripts_versions = array(
-        'react'                       => '18.3.1',
-        'react-dom'                   => '18.3.1',
+        'react'                       => '18.3.1.1', // Final .1 due to switch to UMD build, can be removed in the next update.
+        'react-dom'                   => '18.3.1.1', // Final .1 due to switch to UMD build, can be removed in the next update.
         'react-jsx-runtime'           => '18.3.1',
         'regenerator-runtime'         => '0.14.1',

branches/6.7/tests/phpunit/tests/dependencies/scripts.php

@@ -3414 +3414 @@
         }
 
+        /*
+         * Append '.1' to the version number for React and ReactDOM.
+         *
+         * This is due to a change in the build to use the UMD version of the
+         * scripts, requiring a different version number in order to break the
+         * caches of some CDNs.
+         *
+         * This can be removed in the next update to the packages.
+         *
+         * See https://core.trac.wordpress.org/ticket/62422
+         */
+        if ( in_array( $handle, array( 'react', 'react-dom' ), true ) ) {
+            $package_json[ $script ] .= '.1';
+        }
+
         $script_query = $wp_scripts->query( $handle, 'registered' );