Changeset 59749

Timestamp:

02/01/2025 08:15:09 PM (5 months ago)

Author:

johnbillion

Message:

Build/Test Tools: Parallelise the performance tests.

This change introduces a job matrix for the "current", "before", and "base" performance tests to replace the current behaviour of running them sequentially in a single job. This speeds up the overall performance testing workflow and also reduces the chance of any given test interfering with another, for example by making a change to data in the database that affects a subsequent test.

Props johnbillion, swissspidy, dmsnell, joemcgill.

See #62221

Location:

trunk/.github/workflows

Files:

• performance.yml (modified) (3 diffs)
• reusable-performance-report-v2.yml (added)
• reusable-performance-test-v2.yml (added)

trunk/.github/workflows/performance.yml

@@ -34 +34 @@
       - '.github/workflows/performance.yml'
       - '.github/workflows/reusable-performance.yml'
+      - '.github/workflows/reusable-performance-*.yml'
   workflow_dispatch:
 
@@ -48 +49 @@
 
 jobs:
+  determine-matrix:
+    name: Determine Matrix
+    runs-on: ubuntu-24.04
+    if: ${{ ( github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' ) && ! contains( github.event.before, '00000000' ) }}
+    permissions: {}
+    env:
+      TARGET_SHA: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.sha || github.event.before }}
+    outputs:
+      subjects: ${{ steps.set-subjects.outputs.result }}
+      target_sha: ${{ env.TARGET_SHA }}
+    steps:
+      # The `workflow_dispatch` event is the only one missing the needed SHA to target.
+      - name: Retrieve previous commit SHA (if necessary)
+        if: ${{ github.event_name == 'workflow_dispatch' }}
+        run: echo "TARGET_SHA=$(git rev-parse HEAD^1)" >> "$GITHUB_ENV"
+
+      - name: Set subjects
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
+        id: set-subjects
+        with:
+          script: |
+            const artifacts = await github.rest.actions.listArtifactsForRepo({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              name: 'wordpress-build-' + process.env.TARGET_SHA,
+            });
+            const has_previous_build = !! artifacts.data.artifacts[0];
+
+            const subjects = [
+              'current',
+            ];
+
+            if ( context.eventName === 'push' && context.ref === 'refs/heads/trunk' ) {
+              subjects.push( 'base' );
+            } else if ( has_previous_build ) {
+              subjects.push( 'before' );
+            }
+
+            return subjects;
+
   # Runs the performance test suite.
   performance:
-    name: ${{ matrix.multisite && 'Multisite' || 'Single site' }}
-    uses: ./.github/workflows/reusable-performance.yml
+    name: ${{ matrix.multisite && 'Multisite' || 'Single Site' }} ${{ matrix.memcached && 'Memcached' || 'Default' }}
+    uses: ./.github/workflows/reusable-performance-test-v2.yml
+    needs: [ determine-matrix ]
     permissions:
       contents: read
-    if: ${{ ( github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' ) }}
     strategy:
       fail-fast: false
@@ -60 +101 @@
         memcached: [ true, false ]
         multisite: [ true, false ]
+        subject: ${{ fromJson( needs.determine-matrix.outputs.subjects ) }}
     with:
       memcached: ${{ matrix.memcached }}
       multisite: ${{ matrix.multisite }}
+      subject: ${{ matrix.subject }}
+      TARGET_SHA: ${{ needs.determine-matrix.outputs.target_sha }}
+
+  compare:
+    name: ${{ matrix.label }}
+    uses: ./.github/workflows/reusable-performance-report-v2.yml
+    needs: [ determine-matrix, performance ]
+    permissions:
+      contents: read
+    strategy:
+      fail-fast: false
+      matrix:
+        memcached: [ true, false ]
+        multisite: [ true, false ]
+        label: [ Compare ]
+    with:
+      memcached: ${{ matrix.memcached }}
+      multisite: ${{ matrix.multisite }}
+      BASE_TAG: ${{ needs.performance.outputs.BASE_TAG }}
+      publish: ${{ contains( fromJson( needs.determine-matrix.outputs.subjects ), 'base' ) && ! matrix.memcached && ! matrix.multisite }}
     secrets:
       CODEVITALS_PROJECT_TOKEN: ${{ secrets.CODEVITALS_PROJECT_TOKEN }}