Changeset 59754 for trunk/src/wp-admin/includes/upgrade.php

Timestamp:

02/03/2025 07:50:50 PM (9 months ago)

Author:

johnbillion

Message:

Security: Add the SensitiveParameter attribute to sensitive parameters.

Values passed to parameters with this attribute will be redacted if present in a stack trace when using PHP 8.2 or later. This reduces the chance that passwords and security keys get accidentally exposed in debug logs and bug reports.

Props petitphp, TobiasBg, jrf, johnbillion.

Fixes #57304

File:

• trunk/src/wp-admin/includes/upgrade.php (modified) (2 diffs)

trunk/src/wp-admin/includes/upgrade.php

@@ -45 +45 @@
      * }
      */
-    function wp_install( $blog_title, $user_name, $user_email, $is_public, $deprecated = '', $user_password = '', $language = '' ) {
+    function wp_install(
+        $blog_title,
+        $user_name,
+        $user_email,
+        $is_public,
+        $deprecated = '',
+        #[\SensitiveParameter]
+        $user_password = '',
+        $language = ''
+    ) {
         if ( ! empty( $deprecated ) ) {
             _deprecated_argument( __FUNCTION__, '2.6.0' );
@@ -564 +573 @@
      *                           usually passed instead of the actual password.
      */
-    function wp_new_blog_notification( $blog_title, $blog_url, $user_id, $password ) {
+    function wp_new_blog_notification(
+        $blog_title,
+        $blog_url,
+        $user_id,
+        #[\SensitiveParameter]
+        $password
+    ) {
         $user      = new WP_User( $user_id );
         $email     = $user->user_email;