Changeset 59789

Timestamp:

02/08/2025 03:51:03 PM (18 months ago)

Author:

audrasjb

Message:

Administration: Error messages improvements in WP Admin.

This changeset improves a bunch of WP-Admin error messages, notably replacing the good old cryptic "Something went wrong" message with more helpful information.

Props peterwilsoncc, netweb, karmatosed, JoshuaWold, mrtortai, audrasjb, sukhendu2002, joedolson.
See #43622.

Location:

trunk/src

Files:

• js/_enqueues/admin/tags.js (modified) (1 diff)
• js/_enqueues/lib/ajax-response.js (modified) (1 diff)
• js/_enqueues/wp/theme-plugin-editor.js (modified) (1 diff)
• js/_enqueues/wp/updates.js (modified) (1 diff)
• wp-admin/customize.php (modified) (1 diff)
• wp-admin/includes/class-custom-image-header.php (modified) (3 diffs)
• wp-admin/includes/file.php (modified) (1 diff)
• wp-admin/includes/revision.php (modified) (1 diff)
• wp-admin/media-upload.php (modified) (1 diff)
• wp-admin/network/site-users.php (modified) (1 diff)
• wp-admin/themes.php (modified) (2 diffs)
• wp-admin/users.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/tags.js

@@ -60 +60 @@
 
                                 } else {
-                                        $('#ajax-response').empty().append('<div class="error"><p>' + wp.i18n.__( 'Something went wrong.' ) + '</p></div>');
+                                        $('#ajax-response').empty().append('<div class="error"><p>' + wp.i18n.__( 'An error occurred while processing your request. Please try again later.' ) + '</p></div>');
                                         tr.children().css('backgroundColor', '');
                                 }

trunk/src/js/_enqueues/lib/ajax-response.js

@@ -84 +84 @@
                 return !wpAjax.invalidateForm( selector.find('.form-required').filter( function() { return jQuery('input:visible', this).val() === ''; } ) ).length;
         }
-}, wpAjax || { noPerm: 'Sorry, you are not allowed to do that.', broken: 'Something went wrong.' } );
+}, wpAjax || { noPerm: 'Sorry, you are not allowed to do that.', broken: 'An error occurred while processing your request. Please refresh the page and try again.' } );
 
 // Basic form validation.

trunk/src/js/_enqueues/wp/theme-plugin-editor.js

@@ -227 +227 @@
                                 {
                                         code: 'save_error',
-                                        message: __( 'Something went wrong. Your change may not have been saved. Please try again. There is also a chance that you may need to manually fix and upload the file over FTP.' )
+                                        message: __( 'An error occurred while saving your changes. Please try again. If the problem persists, you may need to manually update the file via FTP.' )
                                 },
                                 response,

trunk/src/js/_enqueues/wp/updates.js

@@ -2334 +2334 @@
          */
         wp.updates.isValidResponse = function( response, action ) {
-                var error = __( 'Something went wrong.' ),
+                var error = __( 'An error occurred during the update process. Please try again.' ),
                         errorMessage;
 

trunk/src/wp-admin/customize.php

@@ -77 +77 @@
         if ( in_array( get_post_status( $changeset_post->ID ), array( 'publish', 'trash' ), true ) ) {
                 wp_die(
-                        '<h1>' . __( 'Something went wrong.' ) . '</h1>' .
-                        '<p>' . __( 'This changeset cannot be further modified.' ) . '</p>' .
+                        '<h1>' . __( 'An error occurred while saving your changeset.' ) . '</h1>' .
+                        '<p>' . __( 'Please try again or start a new changeset. This changeset cannot be further modified.' ) . '</p>' .
                         '<p><a href="' . esc_url( remove_query_arg( 'changeset_uuid' ) ) . '">' . __( 'Customize New Changes' ) . '</a></p>',
                         403

trunk/src/wp-admin/includes/class-custom-image-header.php

@@ -831 +831 @@
                 if ( ! current_theme_supports( 'custom-header', 'uploads' ) ) {
                         wp_die(
-                                '<h1>' . __( 'Something went wrong.' ) . '</h1>' .
-                                '<p>' . __( 'The active theme does not support uploading a custom header image.' ) . '</p>',
+                                '<h1>' . __( 'An error occurred while processing your header image.' ) . '</h1>' .
+                                '<p>' . __( 'The active theme does not support uploading a custom header image. Please ensure your theme supports custom headers and try again.' ) . '</p>',
                                 403
                         );
@@ -1019 +1019 @@
                 if ( ! current_theme_supports( 'custom-header', 'uploads' ) ) {
                         wp_die(
-                                '<h1>' . __( 'Something went wrong.' ) . '</h1>' .
-                                '<p>' . __( 'The active theme does not support uploading a custom header image.' ) . '</p>',
+                                '<h1>' . __( 'An error occurred while processing your header image.' ) . '</h1>' .
+                                '<p>' . __( 'The active theme does not support uploading a custom header image. Please ensure your theme supports custom headers and try again.' ) . '</p>',
                                 403
                         );
@@ -1030 +1030 @@
                 ) {
                         wp_die(
-                                '<h1>' . __( 'Something went wrong.' ) . '</h1>' .
+                                '<h1>' . __( 'An error occurred while processing your header image.' ) . '</h1>' .
                                 '<p>' . __( 'The active theme does not support a flexible sized header image.' ) . '</p>',
                                 403

trunk/src/wp-admin/includes/file.php

@@ -636 +636 @@
 
                         if ( ! isset( $result['message'] ) ) {
-                                $message = __( 'Something went wrong.' );
+                                $message = __( 'An error occurred. Please try again later.' );
                         } else {
                                 $message = $result['message'];

trunk/src/wp-admin/includes/revision.php

@@ -467 +467 @@
         <script id="tmpl-revisions-diff" type="text/html">
                 <div class="loading-indicator"><span class="spinner"></span></div>
-                <div class="diff-error"><?php _e( 'Sorry, something went wrong. The requested comparison could not be loaded.' ); ?></div>
+                <div class="diff-error"><?php _e( 'An error occurred while loading the comparison. Please refresh the page and try again.' ); ?></div>
                 <div class="diff">
                 <# _.each( data.fields, function( field ) { #>

trunk/src/wp-admin/media-upload.php

@@ -36 +36 @@
 if ( isset( $action ) && 'edit' === $action && ! $ID ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName
         wp_die(
-                '<h1>' . __( 'Something went wrong.' ) . '</h1>' .
-                '<p>' . __( 'Invalid item ID.' ) . '</p>',
+                '<h1>' . __( 'An error occurred during the upload process.' ) . '</h1>' .
+                '<p>' . __( 'Invalid item ID. You can view all media items in the <a href="upload.php">Media Library</a>.' ) . '</p>',
                 403
         );

trunk/src/wp-admin/network/site-users.php

@@ -156 +156 @@
                                         if ( ! is_user_member_of_blog( $user_id ) ) {
                                                 wp_die(
-                                                        '<h1>' . __( 'Something went wrong.' ) . '</h1>' .
+                                                        '<h1>' . __( 'An error occurred.' ) . '</h1>' .
                                                         '<p>' . __( 'One of the selected users is not a member of this site.' ) . '</p>',
                                                         403

trunk/src/wp-admin/themes.php

@@ -25 +25 @@
                 if ( ! $theme->exists() || ! $theme->is_allowed() ) {
                         wp_die(
-                                '<h1>' . __( 'Something went wrong.' ) . '</h1>' .
+                                '<h1>' . __( 'An error occurred.' ) . '</h1>' .
                                 '<p>' . __( 'The requested theme does not exist.' ) . '</p>',
                                 403
@@ -68 +68 @@
                 if ( ! $theme->exists() ) {
                         wp_die(
-                                '<h1>' . __( 'Something went wrong.' ) . '</h1>' .
+                                '<h1>' . __( 'An error occurred while deleting the theme.' ) . '</h1>' .
                                 '<p>' . __( 'The requested theme does not exist.' ) . '</p>',
                                 403

trunk/src/wp-admin/users.php

@@ -156 +156 @@
                         if ( is_multisite() && ! is_user_member_of_blog( $id ) ) {
                                 wp_die(
-                                        '<h1>' . __( 'Something went wrong.' ) . '</h1>' .
+                                        '<h1>' . __( 'An error occurred.' ) . '</h1>' .
                                         '<p>' . __( 'One of the selected users is not a member of this site.' ) . '</p>',
                                         403