Changeset 59790

Timestamp:

02/08/2025 03:58:11 PM (10 months ago)

Author:

audrasjb

Message:

General: Error messages improvements in /wp-includes files.

This changeset improves a bunch of error messages, notably replacing the good old cryptic "Something went wrong" message with more helpful information.

Props peterwilsoncc, netweb, karmatosed, JoshuaWold, mrtortai, audrasjb, sukhendu2002, joedolson.
Fixes #43622.

Location:

trunk/src

Files:

• wp-includes/class-wp-customize-manager.php (modified) (1 diff)
• wp-includes/class-wp-xmlrpc-server.php (modified) (3 diffs)
• wp-includes/functions.php (modified) (1 diff)
• wp-includes/script-loader.php (modified) (2 diffs)
• wp-mail.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -455 +455 @@
 
         if ( ! $message ) {
-            $message = __( 'Something went wrong.' );
+            $message = __( 'An error occurred while customizing. Please refresh the page and try again.' );
         }
 

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -4032 +4032 @@
 
         if ( ! $comment_id ) {
-            return new IXR_Error( 403, __( 'Something went wrong.' ) );
+            return new IXR_Error( 403, __( 'An error occurred while processing your comment. Please ensure all fields are filled correctly and try again.' ) );
         }
 
@@ -5052 +5052 @@
 
         if ( ! $posts_list ) {
-            $this->error = new IXR_Error( 500, __( 'Either there are no posts, or something went wrong.' ) );
+            $this->error = new IXR_Error( 500, __( 'No posts found or an error occurred while retrieving posts.' ) );
             return $this->error;
         }
@@ -6585 +6585 @@
 
         if ( ! $posts_list ) {
-            $this->error = new IXR_Error( 500, __( 'Either there are no posts, or something went wrong.' ) );
+            $this->error = new IXR_Error( 500, __( 'No posts found or an error occurred while retrieving posts.' ) );
             return $this->error;
         }

trunk/src/wp-includes/functions.php

@@ -3673 +3673 @@
 function wp_nonce_ays( $action ) {
     // Default title and response code.
-    $title         = __( 'Something went wrong.' );
+    $title         = __( 'An error occurred.' );
     $response_code = 403;
 

trunk/src/wp-includes/script-loader.php

@@ -811 +811 @@
         array(
             'noPerm' => __( 'Sorry, you are not allowed to do that.' ),
-            'broken' => __( 'Something went wrong.' ),
+            'broken' => __( 'An error occurred while processing your request. Please try again later.' ),
         )
     );
@@ -1293 +1293 @@
             'action'                  => __( 'Action' ),
             'discardChanges'          => __( 'Discard changes' ),
-            'cheatin'                 => __( 'Something went wrong.' ),
+            'cheatin'                 => __( 'An error occurred. Please try again later.' ),
             'notAllowedHeading'       => __( 'You need a higher level of permission.' ),
             'notAllowed'              => __( 'Sorry, you are not allowed to customize this site.' ),

trunk/src/wp-mail.php

@@ -40 +40 @@
 
 if ( $last_checked ) {
-    wp_die( __( 'Slow down cowboy, no need to check for new mails so often!' ) );
+    wp_die(
+        sprintf(
+            // translators: %s human readable rate limit.
+            __( 'Email checks are rate limited to once every %s.' ),
+            human_time_diff( time() - WP_MAIL_INTERVAL, time() )
+        ),
+        __( 'Slow down, no need to check for new mails so often!' ),
+        429
+    );
 }