Changeset 59813 for trunk/src/wp-admin/includes/class-custom-background.php

Timestamp:

02/11/2025 09:05:00 PM (3 months ago)

Author:

audrasjb

Message:

Themes: Avoid double hashed value for background-color in custom backgrounds.

This changeset replaces the hardcoded hash symbol with running maybe_hash_hex_color() on the full background-color value provided via the custom background feature, so the hash is only added if it is needed. By doing so, if a theme developer sets a background color value that uses a hash (#), WordPress won't add an additional hash anymore when outputting the relevant CSS. Duplicate hash symbols (##) can break CSS background color declarations.

Props hovhanneshovakimyan, joyously, poena,
Fixes #40057.

File:

• trunk/src/wp-admin/includes/class-custom-background.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-custom-background.php

@@ -289 +289 @@
             $bgcolor           = get_background_color();
             if ( $bgcolor ) {
-                $background_styles .= 'background-color: #' . $bgcolor . ';';
+                $background_styles .= 'background-color: ' . maybe_hash_hex_color( $bgcolor ) . ';';
             }