Changeset 59818

Timestamp:

02/12/2025 11:44:00 PM (5 weeks ago)

Author:

flixos90

Message:

Pings/Trackbacks: Add return value to pingback().

This facilitates debugging and better response / error handling, among other things.

Props audrasjb, coquardcyr, dshanske, ironprogrammer, NathanAtmoz, pbearne, shulard, soulseekah.
Fixes #38197.

Location:

trunk

Files:

• src/wp-includes/comment.php (modified) (5 diffs)
• tests/phpunit/tests/comment/pingback.php (added)

trunk/src/wp-includes/comment.php

@@ -2891 +2891 @@
     $pingback_link_offset_dquote = strpos( $contents, $pingback_str_dquote );
     $pingback_link_offset_squote = strpos( $contents, $pingback_str_squote );
+
     if ( $pingback_link_offset_dquote || $pingback_link_offset_squote ) {
         $quote                   = ( $pingback_link_offset_dquote ) ? '"' : '\'';
@@ -3080 +3081 @@
  * @since 0.71
  * @since 4.7.0 `$post` can be a WP_Post object.
+ * @since 6.8.0 Returns an array of pingback statuses indexed by link.
  *
  * @param string      $content Post content to check for links. If empty will retrieve from post.
  * @param int|WP_Post $post    Post ID or object.
+ * @return array<string, bool> An array of pingback statuses indexed by link.
  */
 function pingback( $content, $post ) {
@@ -3094 +3097 @@
 
     if ( ! $post ) {
-        return;
+        return array();
     }
 
@@ -3109 +3112 @@
     $post_links_temp = wp_extract_urls( $content );
 
+    $ping_status = array();
     /*
      * Step 2.
@@ -3180 +3184 @@
             $client->debug = false;
 
-            if ( $client->query( 'pingback.ping', $pagelinkedfrom, $pagelinkedto ) || ( isset( $client->error->code ) && 48 == $client->error->code ) ) { // Already registered.
+            $status = $client->query( 'pingback.ping', $pagelinkedfrom, $pagelinkedto );
+
+            if ( $status // Ping registered.
+                || ( isset( $client->error->code ) && 48 === $client->error->code ) // Already registered.
+            ) {
                 add_ping( $post, $pagelinkedto );
             }
-        }
-    }
+            $ping_status[ $pagelinkedto ] = $status;
+        }
+    }
+
+    return $ping_status;
 }