Changeset 59853

Timestamp:

02/21/2025 02:50:17 PM (8 weeks ago)

Author:

audrasjb

Message:

Site Health: Improve fonts directory check.

This changeset enhances the filesystem checks in the Site Health debug data by addressing the following:

• Existence Check: Before checking if the fonts directory is writable, it first verifies whether the directory exists.
• Improved Messaging: If the fonts directory does not exist, the debug output now reflects this scenario as "Does not exist". If the directory exists, it shows whether it is writable or not.

Props zodiac1978, samiamnot, sainathpoojary, abcd95, ankitkumarshah, im3dabasia1.
Fixes #62633.

File:

• trunk/src/wp-admin/includes/class-wp-debug-data.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-debug-data.php

@@ -1647 +1647 @@
     private static function get_wp_filesystem(): array {
         $upload_dir                     = wp_upload_dir();
+        $fonts_dir_exists               = file_exists( wp_get_font_dir()['basedir'] );
         $is_writable_abspath            = wp_is_writable( ABSPATH );
         $is_writable_wp_content_dir     = wp_is_writable( WP_CONTENT_DIR );
@@ -1652 +1653 @@
         $is_writable_wp_plugin_dir      = wp_is_writable( WP_PLUGIN_DIR );
         $is_writable_template_directory = wp_is_writable( get_theme_root( get_template() ) );
-        $is_writable_fonts_dir          = wp_is_writable( wp_get_font_dir()['basedir'] );
+        $is_writable_fonts_dir          = $fonts_dir_exists ? wp_is_writable( wp_get_font_dir()['basedir'] ) : false;
 
         $fields = array(
@@ -1682 +1683 @@
             'fonts'      => array(
                 'label' => __( 'The fonts directory' ),
-                'value' => ( $is_writable_fonts_dir ? __( 'Writable' ) : __( 'Not writable' ) ),
-                'debug' => ( $is_writable_fonts_dir ? 'writable' : 'not writable' ),
+                'value' => $fonts_dir_exists
+                    ? ( $is_writable_fonts_dir ? __( 'Writable' ) : __( 'Not writable' ) )
+                    : __( 'Does not exist' ),
+                'debug' => $fonts_dir_exists
+                    ? ( $is_writable_fonts_dir ? 'writable' : 'not writable' )
+                    : 'does not exist',
             ),
         );