Changeset 59899 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-revisions-controller.php

Timestamp:

03/02/2025 10:05:08 PM (3 months ago)

Author:

TimothyBlynJacobs

Message:

REST API: Improve performance for HEAD requests.

By default, the REST API responds to HEAD rqeuests by calling the GET handler and omitting the body from the response. While convenient, this ends up performing needless work that slows down the API response time.

This commit adjusts the Core controllers to specifically handle HEAD requests by not preparing the response body.

Fixes #56481.
Props antonvlasenko, janusdev, ironprogrammer, swissspidy, spacedmonkey, mukesh27, mamaduka, timothyblynjacobs.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-revisions-controller.php (modified) (4 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-revisions-controller.php

@@ -164 +164 @@
         }
 
+        $is_head_request = $request->is_method( 'HEAD' );
+
         if ( wp_revisions_enabled( $parent ) ) {
             $registered = $this->get_collection_params();
@@ -185 +187 @@
                     $query_args[ $wp_param ] = $request[ $api_param ];
                 }
+            }
+
+            if ( $is_head_request ) {
+                // Force the 'fields' argument. For HEAD requests, only post IDs are required to calculate pagination.
+                $query_args['fields'] = 'ids';
+                // Disable priming post meta for HEAD requests to improve performance.
+                $query_args['update_post_term_cache'] = false;
+                $query_args['update_post_meta_cache'] = false;
             }
 
@@ -229 +239 @@
         }
 
-        $response = array();
-
-        foreach ( $revisions as $revision ) {
-            $data       = $this->prepare_item_for_response( $revision, $request );
-            $response[] = $this->prepare_response_for_collection( $data );
-        }
-
-        $response = rest_ensure_response( $response );
+        if ( ! $is_head_request ) {
+            $response = array();
+
+            foreach ( $revisions as $revision ) {
+                $data       = $this->prepare_item_for_response( $revision, $request );
+                $response[] = $this->prepare_response_for_collection( $data );
+            }
+
+            $response = rest_ensure_response( $response );
+        } else {
+            $response = new WP_REST_Response();
+        }
 
         $response->header( 'X-WP-Total', (int) $total_revisions );
@@ -276 +290 @@
      */
     public function prepare_item_for_response( $post, $request ) {
+        // Don't prepare the response body for HEAD requests.
+        if ( $request->is_method( 'HEAD' ) ) {
+            return new WP_REST_Response();
+        }
+
         $parent               = $this->get_parent( $request['parent'] );
         $global_styles_config = $this->get_decoded_global_styles_json( $post->post_content );