Changeset 59901 for trunk/tests/phpunit/tests/multisite/wpmuValidateUserSignup.php

Timestamp:

03/02/2025 11:33:56 PM (3 months ago)

Author:

peterwilsoncc

Message:

Users: Use editable_roles filter for multisite sub-sites.

Adds a check of the editable_roles filter when adding users to a multisite sub-site to ensure the role is permitted to be used on the network. If the role is blocked by the filter, attempting to add the role will trigger a wp_die() similar to attempting to add a user with the role on a single site install.

Props eartboard, hareesh-pillai, ideag, sukhendu2002, spacedmonkey, thomaswm.
Fixes #43251.

File:

• trunk/tests/phpunit/tests/multisite/wpmuValidateUserSignup.php (modified) (1 diff)

trunk/tests/phpunit/tests/multisite/wpmuValidateUserSignup.php

@@ -221 +221 @@
             $this->assertContains( 'invalid_nonce', $valid['errors']->get_error_codes() );
         }
+
+        /**
+         * Ensure that wp_ensure_editable_role does not throw an exception when the role is editable.
+         *
+         * @ticket 43251
+         *
+         * @covers ::wp_ensure_editable_role
+         */
+        public function test_wp_ensure_editable_role_allows_editable_roles() {
+            $role = get_role( 'editor' );
+            $this->assertInstanceOf( 'WP_Role', $role, 'The editor role should exist.' );
+            $this->assertNull( wp_ensure_editable_role( 'editor' ), 'The editor role should be editable.' );
+        }
+
+        /**
+         * Ensure that wp_ensure_editable_role throws an exception for non-existent roles.
+         *
+         * @ticket 43251
+         *
+         * @covers ::wp_ensure_editable_role
+         */
+        public function test_wp_ensure_editable_role_does_not_allow_non_existent_role() {
+            $this->expectException( 'WPDieException' );
+            $role = get_role( 'non-existent-role' );
+            $this->assertNotInstanceOf( 'WP_Role', $role, 'The non-existent-role role should not exist.' );
+            wp_ensure_editable_role( 'non-existent-role' );
+        }
+
+        /**
+         * Ensure that wp_ensure_editable_role throws an exception for roles that are not editable.
+         *
+         * @ticket 43251
+         *
+         * @covers ::wp_ensure_editable_role
+         */
+        public function test_wp_ensure_editable_role_does_not_allow_uneditable_roles() {
+            add_filter(
+                'editable_roles',
+                function ( $roles ) {
+                    unset( $roles['editor'] );
+                    return $roles;
+                }
+            );
+            $this->expectException( 'WPDieException' );
+            $role = get_role( 'editor' );
+            $this->assertInstanceOf( 'WP_Role', $role, 'The editor role should exist.' );
+            wp_ensure_editable_role( 'editor' );
+        }
     }