Changeset 59902 for trunk/src/wp-admin/includes/file.php

Timestamp:

03/03/2025 12:17:08 AM (3 months ago)

Author:

joedolson

Message:

Media: Allow uploading images from URLs without extensions.

Enable download_url() to fetch and verify file types if the URL does not contain a file extension. This allows URL downloads to handle media endpoints like istockphoto.com that use file IDs and formatting arguments to deliver images.

Props masteradhoc, mitogh, joedolson, hellofromTonya, antpb, audrasjb, navi161, dmsnell.
Fixes #54738.

File:

• trunk/src/wp-admin/includes/file.php (modified) (1 diff)

trunk/src/wp-admin/includes/file.php

@@ -1242 +1242 @@
     }
 
+    $mime_type = wp_remote_retrieve_header( $response, 'content-type' );
+    if ( $mime_type && 'tmp' === pathinfo( $tmpfname, PATHINFO_EXTENSION ) ) {
+        $valid_mime_types = array_flip( get_allowed_mime_types() );
+        if ( ! empty( $valid_mime_types[ $mime_type ] ) ) {
+            $extensions     = explode( '|', $valid_mime_types[ $mime_type ] );
+            $new_image_name = substr( $tmpfname, 0, -4 ) . ".{$extensions[0]}";
+            if ( 0 === validate_file( $new_image_name ) ) {
+                if ( rename( $tmpfname, $new_image_name ) ) {
+                    $tmpfname = $new_image_name;
+                }
+
+                if ( ( $tmpfname !== $new_image_name ) && file_exists( $new_image_name ) ) {
+                    unlink( $new_image_name );
+                }
+            }
+        }
+    }
+
     $content_md5 = wp_remote_retrieve_header( $response, 'Content-MD5' );