Changeset 59919

Timestamp:

03/03/2025 09:43:44 PM (20 months ago)

Author:

peterwilsoncc

Message:

Query: Ensure secondary loops populate the full global post.

Modifies WP_Query::the_post() to ensure the entire global post object is populated regardless of the fields parameter initially set by the developer.

In secondary loops, this ensures that get_the_content() and other getter functions operate as documented when called without a post ID and return the appropriate data for the global post object.

This introduces consistency when starting the loop and the fields parameter is set to id=>parent to the behaviour when set to either all or ids.

There is no change to the WP_Query::$posts parameter nor when a query is made without starting the secondary loop, ie without calling WP_Query::the_post().

Props juzar, mukesh27, oglekler, peterwilsoncc, sirlouen, joemcgill.
Fixes #56992.

Location:

trunk

Files:

• src/wp-includes/class-wp-query.php (modified) (2 diffs)
• tests/phpunit/tests/query/cacheResults.php (modified) (2 diffs)
• tests/phpunit/tests/query/thePost.php (added)

trunk/src/wp-includes/class-wp-query.php

@@ -3739 +3739 @@
 
                 if ( ! $this->in_the_loop ) {
-                        // Only prime the post cache for queries limited to the ID field.
-                        $post_ids = array_filter( $this->posts, 'is_numeric' );
-                        // Exclude any falsey values, such as 0.
-                        $post_ids = array_filter( $post_ids );
+                        // Get post IDs to prime incomplete post objects.
+                        $post_ids = array_reduce(
+                                $this->posts,
+                                function ( $carry, $post ) {
+                                        if ( is_numeric( $post ) && $post > 0 ) {
+                                                // Query for post ID.
+                                                $carry[] = $post;
+                                        }
+
+                                        if ( is_object( $post ) && isset( $post->ID ) ) {
+                                                // Query for object, either WP_Post or stdClass.
+                                                $carry[] = $post->ID;
+                                        }
+
+                                        return $carry;
+                                },
+                                array()
+                        );
                         if ( $post_ids ) {
                                 _prime_post_caches( $post_ids, $this->query_vars['update_post_term_cache'], $this->query_vars['update_post_meta_cache'] );
                         }
-                        $post_objects = array_map( 'get_post', $this->posts );
+                        $post_objects = array_map( 'get_post', $post_ids );
                         update_post_author_caches( $post_objects );
                 }
@@ -3765 +3779 @@
 
                 $post = $this->next_post();
+
+                // Get the post ID.
+                if ( is_object( $post ) ) {
+                        $global_post_id = $post->ID;
+                } else {
+                        $global_post_id = $post;
+                }
+
+                // Ensure the global $post is the full post object.
+                $post = get_post( $global_post_id );
                 $this->setup_postdata( $post );
         }

trunk/tests/phpunit/tests/query/cacheResults.php

@@ -1926 +1926 @@
          * @since 6.1.1
          * @ticket 56948
+         * @ticket 56992
          *
          * @covers WP_Query::the_post
@@ -1979 +1980 @@
         public function data_author_cache_warmed_by_the_loop() {
                 return array(
-                        'fields: empty' => array( '' ),
-                        'fields: all'   => array( 'all' ),
-                        'fields: ids'   => array( 'ids' ),
-                        /*
-                         * `id=>parent` is untested pending the resolution of an existing bug.
-                         * See https://core.trac.wordpress.org/ticket/56992
-                         */
+                        'fields: empty'      => array( '' ),
+                        'fields: all'        => array( 'all' ),
+                        'fields: ids'        => array( 'ids' ),
+                        'fields: id=>parent' => array( 'id=>parent' ),
                 );
         }