Changeset 59920

Timestamp:

03/03/2025 10:07:57 PM (2 months ago)

Author:

johnbillion

Message:

Build/Test Tools: Remove redundant escaping from the commit message that's passed to the Slack API.

This escaping is no longer needed since all instances of inline expressions were removed from workflows in r59679. The commit message can now be treated as a plain text string in an environment variable throughout the workflow.

Props johnbillion, swissspidy

Unprops johnblackbourn

See #62221

File:

• trunk/.github/workflows/slack-notifications.yml (modified) (3 diffs)

trunk/.github/workflows/slack-notifications.yml

@@ -136 +136 @@
           retries: 2
           retry-exempt-status-codes: 418
+          result-encoding: string
           script: |
             const commit_details = await github.rest.repos.getCommit({
@@ -144 +145 @@
             return commit_details.data.commit.message;
 
-      - name: Prepare commit message.
-        id: commit-message
-        run: |
-          # shellcheck disable=SC2016
-          COMMIT_MESSAGE="$(echo "${COMMIT_MSG_RAW}" | awk 'NR==1' | sed 's/`/\\`/g' | sed 's/\"/\\\\\\"/g' | sed 's/\$/\\$/g')"
-          echo "commit_message_escaped=${COMMIT_MESSAGE}" >> "$GITHUB_OUTPUT"
-        env:
-          COMMIT_MSG_RAW: ${{ ( github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' ) && fromJson( steps.current-commit-message.outputs.result ) || github.event.head_commit.message }}
-
       - name: Construct payload and store as an output
         id: create-payload
         run: |
+          COMMIT_MSG="$(echo "${COMMIT_MSG_RAW}" | awk 'NR==1')"
           PAYLOAD="$( jq \
             -n \
@@ -166 +159 @@
           echo "payload=$PAYLOAD" >> "$GITHUB_OUTPUT"
         env:
-          COMMIT_MSG: ${{ steps.commit-message.outputs.commit_message_escaped }}
+          COMMIT_MSG_RAW: ${{ ( github.event_name == 'workflow_dispatch' || github.event_name == 'schedule' ) && fromJson( steps.current-commit-message.outputs.result ) || github.event.head_commit.message }}
 
   # Posts notifications when a workflow fails.