Changeset 59926

Timestamp:

03/04/2025 01:48:58 PM (7 weeks ago)

Author:

johnbillion

Message:

Upgrade/Install: Prevent an unnecessary plugin update check when the plugin update data is up to date.

This ensures the checked property is always populated with the latest plugin data before determining whether to perform an update check. Previously this was only populated when the data was already identified as being stale, which could result in a subsequent unnecessary update check when viewing the Plugins screen.

Props siliconforks, bookdude13, pbiron, francina, Cybr, snehapatil02, johnbillion

Fixes #44118, #61055

File:

• trunk/src/wp-includes/update.php (modified) (3 diffs)

trunk/src/wp-includes/update.php

@@ -338 +338 @@
     }
 
-    $updates               = new stdClass();
-    $updates->last_checked = time();
-    $updates->response     = array();
-    $updates->translations = array();
-    $updates->no_update    = array();
-
     $doing_cron = wp_doing_cron();
 
@@ -372 +366 @@
 
         foreach ( $plugins as $file => $p ) {
-            $updates->checked[ $file ] = $p['Version'];
-
             if ( ! isset( $current->checked[ $file ] ) || (string) $current->checked[ $file ] !== (string) $p['Version'] ) {
                 $plugin_changed = true;
@@ -460 +452 @@
     if ( is_wp_error( $raw_response ) || 200 !== wp_remote_retrieve_response_code( $raw_response ) ) {
         return;
+    }
+
+    $updates               = new stdClass();
+    $updates->last_checked = time();
+    $updates->response     = array();
+    $updates->translations = array();
+    $updates->no_update    = array();
+    foreach ( $plugins as $file => $p ) {
+        $updates->checked[ $file ] = $p['Version'];
     }