Changeset 59954 for trunk/tests/phpunit/tests/media.php

Timestamp:

03/09/2025 09:14:28 AM (2 months ago)

Author:

audrasjb

Message:

Media: Improve HTML5 compliance of wp_video_shortcode() boolean attributes.

This changeset updates wp_video_shortcode() to improve boolean attributes handling in accordance with HTML5 standards. Technically, it replaces attr="1" with attr for the loop, autoplay and muted attributes. The preload attribute is also updated to accept only allowed values: none, metadata, and auto. If a value outside of this list is provided, it will be ignored, preventing invalid attribute outputs.

Props jongycastillo, sabernhardt, joedolson, audrasjb, shub07, debarghyabanerjee.
Fixes #60178.

File:

• trunk/tests/phpunit/tests/media.php (modified) (2 diffs)

trunk/tests/phpunit/tests/media.php

@@ -1061 +1061 @@
                 'autoplay' => true,
                 'muted'    => true,
-                'preload'  => true,
+                'preload'  => 'metadata',
                 'width'    => 123,
                 'height'   => 456,
@@ -1070 +1070 @@
         $this->assertStringContainsString( 'src="https://example.com/foo.mp4', $actual );
         $this->assertStringContainsString( 'poster="https://example.com/foo.png', $actual );
-        $this->assertStringContainsString( 'loop="1"', $actual );
-        $this->assertStringContainsString( 'autoplay="1"', $actual );
+        $this->assertStringContainsString( 'loop', $actual );
+        $this->assertStringContainsString( 'autoplay', $actual );
         $this->assertStringContainsString( 'muted', $actual );
-        $this->assertStringContainsString( 'preload="1"', $actual );
+        $this->assertStringContainsString( 'preload="metadata"', $actual );
         $this->assertStringContainsString( 'width="123"', $actual );
         $this->assertStringContainsString( 'height="456"', $actual );