Changeset 59956

Timestamp:

03/09/2025 03:15:05 PM (7 weeks ago)

Author:

johnbillion

Message:

Upgrade/Install: Adjust the check for missing extensions during an upgrade so it remains compatible with versions of WordPress prior to 5.1.

The WP_Error::has_errors() method was introduced in WordPress 5.1, so this change uses its internal logic instead to remain compatible with earlier versions.

Props swissspidy, joemcgill, desrosj.

Fixes #63052

Location:

trunk

Files:

• .github/workflows/upgrade-develop-testing.yml (modified) (2 diffs)
• src/wp-admin/includes/update-core.php (modified) (1 diff)

trunk/.github/workflows/upgrade-develop-testing.yml

@@ -64 +64 @@
         db-type: [ 'mysql' ]
         db-version: [ '5.7', '8.4' ]
-        wp: [ '6.5', '6.6', '6.7' ]
+        # WordPress 4.9 is the oldest version that supports PHP 7.2.
+        wp: [ '4.9', '6.5', '6.6', '6.7' ]
         multisite: [ false, true ]
 
@@ -71 +72 @@
           - php: '7.2'
             db-version: '8.4'
+          # WordPress 4.9 does not support PHP 8.4.
+          - php: '8.4'
+            wp: '4.9'
     with:
       os: ${{ matrix.os }}

trunk/src/wp-admin/includes/update-core.php

@@ -1200 +1200 @@
 
         // Add a warning when required PHP extensions are missing.
-        if ( $missing_extensions->has_errors() ) {
+        if ( ! empty( $missing_extensions->errors ) ) {
             return $missing_extensions;
         }