Changeset 59957

Timestamp:

03/09/2025 11:02:41 PM (18 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in check_comment().

Follow-up to [1012], [1737], [48121].

Props aristath, poena, afercia, SergeyBiryukov.
See #62279.

File:

• trunk/src/wp-includes/comment.php (modified) (2 diffs)

trunk/src/wp-includes/comment.php

@@ -41 +41 @@
 
         // If manual moderation is enabled, skip all checks and return false.
-        if ( 1 == get_option( 'comment_moderation' ) ) {
+        if ( '1' === get_option( 'comment_moderation' ) ) {
                 return false;
         }
@@ -127 +127 @@
          * email address. If both checks pass, return true. Otherwise, return false.
          */
-        if ( 1 == get_option( 'comment_previously_approved' ) ) {
+        if ( '1' === get_option( 'comment_previously_approved' ) ) {
                 if ( 'trackback' !== $comment_type && 'pingback' !== $comment_type && '' !== $author && '' !== $email ) {
                         $comment_user = get_user_by( 'email', wp_unslash( $email ) );
                         if ( ! empty( $comment_user->ID ) ) {
-                                $ok_to_comment = $wpdb->get_var( $wpdb->prepare( "SELECT comment_approved FROM $wpdb->comments WHERE user_id = %d AND comment_approved = '1' LIMIT 1", $comment_user->ID ) );
+                                $ok_to_comment = $wpdb->get_var(
+                                        $wpdb->prepare(
+                                                "SELECT comment_approved
+                                                FROM $wpdb->comments
+                                                WHERE user_id = %d
+                                                AND comment_approved = '1'
+                                                LIMIT 1",
+                                                $comment_user->ID
+                                        )
+                                );
                         } else {
                                 // expected_slashed ($author, $email)
-                                $ok_to_comment = $wpdb->get_var( $wpdb->prepare( "SELECT comment_approved FROM $wpdb->comments WHERE comment_author = %s AND comment_author_email = %s and comment_approved = '1' LIMIT 1", $author, $email ) );
+                                $ok_to_comment = $wpdb->get_var(
+                                        $wpdb->prepare(
+                                                "SELECT comment_approved
+                                                FROM $wpdb->comments
+                                                WHERE comment_author = %s
+                                                AND comment_author_email = %s
+                                                AND comment_approved = '1'
+                                                LIMIT 1",
+                                                $author,
+                                                $email
+                                        )
+                                );
                         }
-                        if ( ( 1 == $ok_to_comment ) &&
-                                ( empty( $mod_keys ) || ! str_contains( $email, $mod_keys ) ) ) {
-                                        return true;
+
+                        if ( '1' === $ok_to_comment && ( empty( $mod_keys ) || ! str_contains( $email, $mod_keys ) ) ) {
+                                return true;
                         } else {
                                 return false;