Changeset 59968 for trunk/src/wp-includes/class-wp-theme.php

Timestamp:

03/11/2025 12:31:07 PM (6 weeks ago)

Author:

joemcgill

Message:

Themes: Fix resolution of parent themes.

This fixes an issue introduced in [59885] whereby calling WP_Theme:is_block_theme() before themes are set up resulted in the parent theme to not be resolved. To address this, post support for editor default-mode has been moved to a standalone callback, wp_set_editor_default_mode(), which is called on the after_setup_theme hook. In addition, if WP_Theme::is_block_theme is called too early, a _doing_it_wrong() error will now be thrown.

Props fabiankaegy, joemcgill, peterwilsoncc, jorbin, krupajnanda, riddhidave, ugyensupport, navi161, manojmaharrshi, Ankit K Gupta, narenin, shailu25, pooja1210.
Fixes #63062.

File:

• trunk/src/wp-includes/class-wp-theme.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-theme.php

@@ -1577 +1577 @@
      */
     public function is_block_theme() {
+        if ( ! did_action( 'setup_theme' ) ) {
+            _doing_it_wrong( __METHOD__, __( 'This method should not be called before themes are set up.' ), '6.8.0' );
+            return false;
+        }
+
         if ( isset( $this->block_theme ) ) {
             return $this->block_theme;