Make WordPress Core


Ignore:
Timestamp:
03/11/2025 02:17:41 PM (3 months ago)
Author:
TimothyBlynJacobs
Message:

REST API: Fix fatal error when making HEAD requests with _fields filter.

In [59889] the REST API controllers were adjusted to perform less work when responding to HEAD requests. The WP_REST_Response body would now be null, which caused issues with filters that expected the response body to be an array.

This commit sets the response body to be an empty array when preparing the response instead. The body will still be discarded, but this provides better backward comppatibility with code that assumes an array will be used.

See #56481.
Props antonvlasenko, timothyblynjacobs, mamaduka, wildworks.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php

    r59899 r59970  
    139139        if ( $request->is_method( 'HEAD' ) ) {
    140140            // Return early as this handler doesn't add any response headers.
    141             return new WP_REST_Response();
     141            return new WP_REST_Response( array() );
    142142        }
    143143
     
    687687        if ( $request->is_method( 'HEAD' ) ) {
    688688            /** This filter is documented in wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php */
    689             return apply_filters( 'rest_prepare_widget', new WP_REST_Response(), $widget, $request );
     689            return apply_filters( 'rest_prepare_widget', new WP_REST_Response( array() ), $widget, $request );
    690690        }
    691691
Note: See TracChangeset for help on using the changeset viewer.