Changeset 59985 for trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

Timestamp:

03/15/2025 11:26:50 PM (10 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in some newly introduced tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [59630].

See #62278.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -5945 +5945 @@
         $request->set_param( 'per_page', 1 );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
         $this->assertCount( 1, $data );
-        $this->assertEquals( 30, $response->get_headers()['X-WP-Total'] );
-        $this->assertEquals( 30, $response->get_headers()['X-WP-TotalPages'] );
+        $this->assertSame( 30, $response->get_headers()['X-WP-Total'] );
+        $this->assertSame( 30, $response->get_headers()['X-WP-TotalPages'] );
 
         // Test paged.
@@ -5956 +5956 @@
         $request->set_param( 'per_page', 2 );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
         $this->assertCount( 2, $data );
-        $this->assertEquals( 30, $response->get_headers()['X-WP-Total'] );
-        $this->assertEquals( 15, $response->get_headers()['X-WP-TotalPages'] );
+        $this->assertSame( 30, $response->get_headers()['X-WP-Total'] );
+        $this->assertSame( 15, $response->get_headers()['X-WP-TotalPages'] );
 
         // Test out of bounds.