Changeset 59986

Timestamp:

03/16/2025 04:09:13 PM (18 months ago)

Author:

joedolson

Message:

Media: Dismiss button not functional on upload errors.

Change the onclick attribute to a separate inlined script in the error message and improve the event attachment behavior.

Props vivekawsm, mijotj, adamsilverstein, parthvataliya, adhun, sarathar, peterwilsoncc, sayedulsayem, chaion07, sppramodh, indirabiswas27, aishwarryapande, dhrumilk, manojmaharrshi, ugyensupport, imranhasanraaz, pkbhatt, shailu25, joedolson.
Fixes #60074.

Location:

trunk

Files:

• src/wp-admin/async-upload.php (modified) (2 diffs)
• tests/e2e/assets (added)
• tests/e2e/assets/sample.svg (added)
• tests/e2e/specs/media-upload.test.js (added)

trunk/src/wp-admin/async-upload.php

@@ -113 +113 @@
 $id = media_handle_upload( 'async-upload', $post_id );
 if ( is_wp_error( $id ) ) {
-        $message = sprintf(
+        $button_unique_id = uniqid( 'dismiss-' );
+        $message          = sprintf(
                 '%s <strong>%s</strong><br />%s',
                 sprintf(
-                        '<button type="button" class="dismiss button-link" onclick="jQuery(this).parents(\'div.media-item\').slideUp(200, function(){jQuery(this).remove();});">%s</button>',
+                        '<button type="button" id="%s" class="dismiss button-link">%s</button>',
+                        esc_attr( $button_unique_id ),
                         __( 'Dismiss' )
                 ),
@@ -133 +135 @@
                 )
         );
+        echo "<script>jQuery( 'button#{$button_unique_id}' ).on( 'click', function() {jQuery(this).parents('div.media-item').slideUp(200, function(){jQuery(this).remove();})});</script>\n";
         exit;
 }