Changeset 60031

Timestamp:

03/17/2025 05:46:51 PM (5 weeks ago)

Author:

adamsilverstein

Message:

Media: disable "Insert Gallery" button during uploads.

Ensure that the button to insert a gallery is disabled until all image uploads have completed on the Edit Gallery screen. Prevents an issue where users could insert a gallery with some images missing.

Props: adamsilverstein, gonom9, rishavdutta.
Fixes: #39824.

Location:

trunk/src/js/media/views

Files:

• frame/post.js (modified) (1 diff)
• toolbar.js (modified) (2 diffs)

trunk/src/js/media/views/frame/post.js

@@ -581 +581 @@
                     text:     editing ? l10n.updateGallery : l10n.insertGallery,
                     priority: 80,
-                    requires: { library: true },
+                    requires: { library: true, uploadingComplete: true },
 
                     /**

trunk/src/js/media/views/toolbar.js

@@ -144 +144 @@
 
             var requires = button.options.requires,
-                disabled = false;
+                disabled = false,
+                modelsUploading = ! _.isEmpty( library.findWhere(  { 'uploading': true } ) );
 
             // Prevent insertion of attachments if any of them are still uploading.
@@ -151 +152 @@
                     return attachment.get('uploading') === true;
                 });
+            }
+            if ( requires.uploadingComplete && modelsUploading ) {
+                disabled = true;
             }