Changeset 60068

Timestamp:

03/22/2025 04:06:25 PM (5 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in REST API attachments controller tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [48291], [50124], [57603].

See #62278.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (5 diffs)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -1103 +1103 @@
         $data     = $response->get_data();
 
-        $this->assertEquals( 201, $response->get_status() );
+        $this->assertSame( 201, $response->get_status() );
 
         $new_attachment = get_post( $data['id'] );
 
-        $this->assertEquals( $attachment_id, (int) get_post_thumbnail_id( $new_attachment->ID ) );
-        $this->assertEquals( $attachment_id, $data['featured_media'] );
+        $this->assertSame( $attachment_id, get_post_thumbnail_id( $new_attachment->ID ) );
+        $this->assertSame( $attachment_id, $data['featured_media'] );
 
         $request = new WP_REST_Request( 'PUT', '/wp/v2/media/' . $new_attachment->ID );
@@ -1118 +1118 @@
         $request->set_body_params( $params );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertEquals( 0, $data['featured_media'] );
-        $this->assertEquals( 0, (int) get_post_thumbnail_id( $new_attachment->ID ) );
+        $this->assertSame( 0, $data['featured_media'] );
+        $this->assertSame( 0, get_post_thumbnail_id( $new_attachment->ID ) );
 
         $request = new WP_REST_Request( 'PUT', '/wp/v2/media/' . $new_attachment->ID );
@@ -1131 +1131 @@
         $request->set_body_params( $params );
         $response = rest_get_server()->dispatch( $request );
-        $this->assertEquals( 200, $response->get_status() );
+        $this->assertSame( 200, $response->get_status() );
         $data = $response->get_data();
-        $this->assertEquals( $attachment_id, $data['featured_media'] );
-        $this->assertEquals( $attachment_id, (int) get_post_thumbnail_id( $new_attachment->ID ) );
+        $this->assertSame( $attachment_id, $data['featured_media'] );
+        $this->assertSame( $attachment_id, get_post_thumbnail_id( $new_attachment->ID ) );
     }
 
@@ -2443 +2443 @@
         $this->assertStringEndsWith( '-edited.jpg', $item['media_details']['file'] );
         $this->assertArrayHasKey( 'parent_image', $item['media_details'] );
-        $this->assertEquals( $attachment, $item['media_details']['parent_image']['attachment_id'] );
+        $this->assertSame( (string) $attachment, $item['media_details']['parent_image']['attachment_id'] );
         $this->assertStringContainsString( 'canola', $item['media_details']['parent_image']['file'] );
     }
@@ -2486 +2486 @@
         $this->assertStringEndsWith( '-edited.jpg', $item['media_details']['file'] );
         $this->assertArrayHasKey( 'parent_image', $item['media_details'] );
-        $this->assertEquals( $attachment, $item['media_details']['parent_image']['attachment_id'] );
+        $this->assertSame( (string) $attachment, $item['media_details']['parent_image']['attachment_id'] );
         $this->assertStringContainsString( 'canola', $item['media_details']['parent_image']['file'] );
     }