Changeset 60070 for trunk/src/wp-includes/interactivity-api/class-wp-interactivity-api.php

Timestamp:

03/24/2025 02:51:19 PM (8 months ago)

Author:

joemcgill

Message:

Interactivity API: Apply the same directive name restrictions as the client.

This adds the same logic to filter directive data attributes to ignore invalid data attributes that is applied in the client to avoid processing directives on the server that will not be processed in the client.

Props jonsurrell, SirLouen.
Fixes #62426.

File:

• trunk/src/wp-includes/interactivity-api/class-wp-interactivity-api.php (modified) (1 diff)

trunk/src/wp-includes/interactivity-api/class-wp-interactivity-api.php

@@ -452 +452 @@
                     // Checks if there is a server directive processor registered for each directive.
                     foreach ( $p->get_attribute_names_with_prefix( 'data-wp-' ) as $attribute_name ) {
+                        if ( ! preg_match(
+                            /*
+                             * This must align with the client-side regex used by the interactivity API.
+                             * @see https://github.com/WordPress/gutenberg/blob/ca616014255efbb61f34c10917d52a2d86c1c660/packages/interactivity/src/vdom.ts#L20-L32
+                             */
+                            '/' .
+                            '^data-wp-' .
+                            // Match alphanumeric characters including hyphen-separated
+                            // segments. It excludes underscore intentionally to prevent confusion.
+                            // E.g., "custom-directive".
+                            '([a-z0-9]+(?:-[a-z0-9]+)*)' .
+                            // (Optional) Match '--' followed by any alphanumeric charachters. It
+                            // excludes underscore intentionally to prevent confusion, but it can
+                            // contain multiple hyphens. E.g., "--custom-prefix--with-more-info".
+                            '(?:--([a-z0-9_-]+))?$' .
+                            '/i',
+                            $attribute_name
+                        ) ) {
+                            continue;
+                        }
                         list( $directive_prefix ) = $this->extract_prefix_and_suffix( $attribute_name );
                         if ( array_key_exists( $directive_prefix, self::$directive_processors ) ) {