Changeset 60084 for trunk/src/wp-admin/includes/media.php

Timestamp:

03/25/2025 02:04:47 PM (3 months ago)

Author:

adamsilverstein

Message:

Media: prevent uploading image types the server doesn’t support.

Normalize behavior between uploading in the media library and uploading directly to the block editor. Now, when uploading an image with a mime type the server does not support (either in the media library or the block editor), the user will see an error message “This image cannot be processed by the web server. Convert it to JPEG or PNG before uploading”.

Alos, add a new filter wp_prevent_unsupported_mime_type_uploads which determines whether the server should prevent uploads for image types it doesn't support. The default value is true and the filter also receives the uploaded image mime type.

Props: joomskys, adamsilverstein, azaozz, swissspidy, joemcgill, flixos90, audrasjb. 

Fixes #61167

File:

• trunk/src/wp-admin/includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -2195 +2195 @@
     }
 
-    // Check if WebP images can be edited.
-    if ( ! wp_image_editor_supports( array( 'mime_type' => 'image/webp' ) ) ) {
-        $plupload_init['webp_upload_error'] = true;
-    }
-
-    // Check if AVIF images can be edited.
-    if ( ! wp_image_editor_supports( array( 'mime_type' => 'image/avif' ) ) ) {
-        $plupload_init['avif_upload_error'] = true;
+    /** This filter is documented in wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php */
+    $prevent_unsupported_uploads = apply_filters( 'wp_prevent_unsupported_mime_type_uploads', true, null );
+
+    if ( $prevent_unsupported_uploads ) {
+        // Check if WebP images can be edited.
+        if ( ! wp_image_editor_supports( array( 'mime_type' => 'image/webp' ) ) ) {
+            $plupload_init['webp_upload_error'] = true;
+        }
+
+        // Check if AVIF images can be edited.
+        if ( ! wp_image_editor_supports( array( 'mime_type' => 'image/avif' ) ) ) {
+            $plupload_init['avif_upload_error'] = true;
+        }
     }