Changeset 60094

Timestamp:

03/25/2025 06:34:48 PM (3 weeks ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Remove a one-time $sql variable in WP_Importer methods.

This allows the $wpdb::prepare() calls to be picked up correctly by PHPCS.

Follow-up to [14760].

Props aristath, poena, afercia, SergeyBiryukov.
See #63168.

File:

• trunk/src/wp-admin/includes/class-wp-importer.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-importer.php

@@ -30 +30 @@
         do {
             $meta_key = $importer_name . '_' . $blog_id . '_permalink';
-            $sql      = $wpdb->prepare( "SELECT post_id, meta_value FROM $wpdb->postmeta WHERE meta_key = %s LIMIT %d,%d", $meta_key, $offset, $limit );
-            $results  = $wpdb->get_results( $sql );
+            $results  = $wpdb->get_results(
+                $wpdb->prepare(
+                    "SELECT post_id, meta_value FROM $wpdb->postmeta WHERE meta_key = %s LIMIT %d,%d",
+                    $meta_key,
+                    $offset,
+                    $limit
+                )
+            );
 
             // Increment offset.
@@ -63 +69 @@
         // Get count of permalinks.
         $meta_key = $importer_name . '_' . $blog_id . '_permalink';
-        $sql      = $wpdb->prepare( "SELECT COUNT( post_id ) AS cnt FROM $wpdb->postmeta WHERE meta_key = %s", $meta_key );
-
-        $result = $wpdb->get_results( $sql );
+        $result   = $wpdb->get_results(
+            $wpdb->prepare(
+                "SELECT COUNT( post_id ) AS cnt FROM $wpdb->postmeta WHERE meta_key = %s",
+                $meta_key
+            )
+        );
 
         if ( ! empty( $result ) ) {
@@ -92 +101 @@
         // Grab all comments in chunks.
         do {
-            $sql     = $wpdb->prepare( "SELECT comment_ID, comment_agent FROM $wpdb->comments LIMIT %d,%d", $offset, $limit );
-            $results = $wpdb->get_results( $sql );
+            $results = $wpdb->get_results(
+                $wpdb->prepare(
+                    "SELECT comment_ID, comment_agent FROM $wpdb->comments LIMIT %d,%d",
+                    $offset,
+                    $limit
+                )
+            );
 
             // Increment offset.