Changeset 60126

Timestamp:

04/03/2025 02:46:09 PM (6 weeks ago)

Author:

desrosj

Message:

Security: Don't fail the Argon2-related tests when it's not available on the test infrastructure.

These tests are not critical to the bcrypt functionality, they exist to reaffirm that the underlying use of password_hash() and password_verify() supports this algorithm. The Argon2 tests therefore shouldn't unnecessarily fail on hosts that don't support it.

Reviewed by desrosj.
Merges [60124] to the 6.8 branch.

Props desrosj, johnbillion.
Fixes #21022.

Location:

branches/6.8

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/auth.php (modified) (2 diffs)

branches/6.8/tests/phpunit/tests/auth.php

@@ -289 +289 @@
     public function test_wp_check_password_supports_argon2i_hash() {
         if ( ! defined( 'PASSWORD_ARGON2I' ) ) {
-            $this->fail( 'Argon2i is not supported.' );
+            $this->markTestSkipped( 'Argon2i is not supported.' );
         }
 
@@ -307 +307 @@
     public function test_wp_check_password_supports_argon2id_hash() {
         if ( ! defined( 'PASSWORD_ARGON2ID' ) ) {
-            $this->fail( 'Argon2id is not supported.' );
+            $this->markTestSkipped( 'Argon2id is not supported.' );
         }