Changeset 60132

Timestamp:

04/06/2025 08:54:08 PM (3 weeks ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Remove unnecessary conditional in WP_List_Table::print_column_headers().

This commit removes an unnecessary empty() check, where the $class variable is primed at the top of the foreach loop and will always be a non-empty array.

To maintain readability of the source of the $class attribute without the unnecessary empty() check, the resulting variable has been renamed to $class_attr, instead of reusing the array.

Follow-up to [8923], [15491].

Props justlevine.
See #52217.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -1525 +1525 @@
             }
 
-            $tag   = ( 'cb' === $column_key ) ? 'td' : 'th';
-            $scope = ( 'th' === $tag ) ? 'scope="col"' : '';
-            $id    = $with_id ? "id='$column_key'" : '';
-
-            if ( ! empty( $class ) ) {
-                $class = "class='" . implode( ' ', $class ) . "'";
-            }
-
-            echo "<$tag $scope $id $class $aria_sort_attr $abbr_attr>$column_display_name</$tag>";
+            $tag        = ( 'cb' === $column_key ) ? 'td' : 'th';
+            $scope      = ( 'th' === $tag ) ? 'scope="col"' : '';
+            $id         = $with_id ? "id='$column_key'" : '';
+            $class_attr = "class='" . implode( ' ', $class ) . "'";
+
+            echo "<$tag $scope $id $class_attr $aria_sort_attr $abbr_attr>$column_display_name</$tag>";
         }
     }